-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated MMU settings for Nokia 400g and 100g HWSKUs #18239
Conversation
@saksarav-nokia please review |
for arista hwsku - #18500 |
@vmittal-msft , wondering how these numbers were chosen? Were there any performance tests done? Or these were recommended by Nokia team which did run rigorous performance testing and resulted to this numbers for the community to consume? If you can add some support info in the description that would be helpful. |
@gechiang These numbers are chosen based on internal discussion with RDMA team and field experience. We will have sai release matching with these changes as well (It helps with expanded buffers for PG). |
Adding dump from HW tables to facilitate code review - |
@saksarav-nokia please review. |
43e4e94
to
48c7d8a
Compare
'/azpw ms_conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked it with Sakthi . It looks good.
Anshu already ran the sonic-mgmt Qos and verified this PR and adjusted the Qos.yml.. Looks good. |
@vmittal-msft This change requires to modify the expected result to pass the UT in image build. |
/azpw run |
/azp run |
Commenter does not have sufficient privileges for PR 18239 in repo sonic-net/sonic-buildimage |
/azpw ms_conflict |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@vmittal-msft build is failing due to the following testcase failure:
|
@saksarav-nokia please review latest settings. |
@vmittal-msft please share MSFT ADO number for this PR |
Done |
* Updated MMU settings for Nokia 400g and 100g HWSKUs * Updated Nokia MMU settings for dynamic threholding
* Updated MMU settings for Nokia 400g and 100g HWSKUs * Updated Nokia MMU settings for dynamic threholding
* Updated MMU settings for Nokia 400g and 100g HWSKUs * Updated Nokia MMU settings for dynamic threholding
Cherry-pick PR to 202405: #19799 |
* Updated MMU settings for Nokia 400g and 100g HWSKUs * Updated Nokia MMU settings for dynamic threholding
Why I did it
Updated MMU settings to enhance performance for RDMA traffic in production.
Work item tracking
How I did it
Updated device files for buffer pool/profile settings.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)