add support for save-on-set to gnmi #18481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure this test won't pass until sonic-net/sonic-gnmi#108 is merged. |
|
/azpw ms_conflict |
baxia-lan
approved these changes
May 23, 2024
|
/azpw ms_conflict |
|
Hi @lguohan, ms_conflict check is failing, is this check for ms internal repo? Could you please help to resolve this? cc. @StormLiangMS,@liushilongbuaa as mentioned in the conflict msg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design:
sonic-net/SONiC#1297
Paired PR:
sonic-net/sonic-gnmi#108
Why I did it
This enables the ability to turn on save-on-set for sonic-gnmi with a configDB entry.
How I did it
Adds to the telemetry binary command line flags if the db value is present.