Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the dpkg lock to container path #18517

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

w1nda
Copy link
Member

@w1nda w1nda commented Apr 1, 2024

Why I did it

Because dpkg does not allow installing packages in parallel, we added a lock.

The lock is under repo path target/debs/$(BLDENV)/dpkg_lock, when the building progress is terminated by user, and the lock is not cleaned, the next time building progress will stuck at dpkg command.

As the lock should only exists when building, we raise this PR to migrate the lock to container path, so the lock will live on in the container.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Migrate the lock to folder /tmp/dpkg_lock which is in the container.

How to verify it

Triger the pipeline for build

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@w1nda w1nda requested review from saiarcot895 and xumia and removed request for lguohan, qiluo-msft and xumia April 1, 2024 04:19
slave.mk Outdated Show resolved Hide resolved
@liushilongbuaa
Copy link
Contributor

/azpw ms_conflict

@saiarcot895
Copy link
Contributor

platform/mellanox/mft/Makefile is also managing dpkg_lock,, this path may need to be updated (ideally, they shouldn't be doing any package installations at that stage at all).

@w1nda w1nda requested a review from liushilongbuaa April 16, 2024 05:45
@w1nda
Copy link
Member Author

w1nda commented Apr 16, 2024

Hi @xumia,
Hi @liushilongbuaa,
cloud you help review this PR?
thanks

@w1nda
Copy link
Member Author

w1nda commented Apr 16, 2024

platform/mellanox/mft/Makefile is also managing dpkg_lock,, this path may need to be updated (ideally, they shouldn't be doing any package installations at that stage at all).

As the Makefile is not commonly used, I prefer to leave it as it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants