Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new HwSKUs for Arista-7060dx5-32 #18541

Closed
wants to merge 1 commit into from
Closed

Add new HwSKUs for Arista-7060dx5-32 #18541

wants to merge 1 commit into from

Conversation

bobbymcgonigle
Copy link
Contributor

@bobbymcgonigle bobbymcgonigle commented Apr 2, 2024

Why I did it

New desired configurations on this Arista SKU

Work item tracking
  • Microsoft ADO (number only):

How I did it

Added the hwsku folders with the necessary files to populate config_db

How to verify it

change default sku and generate a new config_db.json

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202311

Tested branch (Please provide the tested image version)

  • 202305

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link
Collaborator

@zhenggen-xu zhenggen-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add buffer/qos config files similar to Arista-7060DX5-32 to the new HWKSUs?

Copy link
Collaborator

@zhenggen-xu zhenggen-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use the same th4XXX.bcm file for both HWSKUs? We should make the bcm file agnostic to HWSKUs, and let SONiC SAI APIs to add/delete ports during the initialization, this will make future HWSKU creation straightforward.

@bobbymcgonigle
Copy link
Contributor Author

Is it possible to use the same th4XXX.bcm file for both HWSKUs? We should make the bcm file agnostic to HWSKUs, and let SONiC SAI APIs to add/delete ports during the initialization, this will make future HWSKU creation straightforward.

Unfortunatly this is not available in 202305 (where we would like this to go) due to CSP case CS00012347969. This is fixed in SAI 9.

Until 202305 moves to that SAI version we cannot support the single bcm file.

Can you add buffer/qos config files similar to Arista-7060DX5-32 to the new HWKSUs?

We are planning to do this in a seperate PR. For now we would like to get these hwsku's merged to unblock testing with these front panel configurations.

Copy link
Collaborator

@zhenggen-xu zhenggen-xu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bobbymcgonigle bobbymcgonigle closed this by deleting the head repository Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants