PAC changes to receive config updates #18620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sutharsansr
reviewed
Aug 25, 2024
|
|
||
| // Configure port learning mode for FDB manager | ||
| fvVector.emplace_back("learn_mode", learning); | ||
| m_stateOperPortTable.set(key, fvVector); |
There was a problem hiding this comment.
This sets the value of the learning mode in the STATE_DB of PAC. Should we update this to the APPL_DB of port table also so that it is pushed down
There was a problem hiding this comment.
PAC doesn't interact directly with the Orch agent. The Orch agent updates are done using VLAN mgr. Hence PAC uses STATE_DB .
sutharsansr
approved these changes
Sep 30, 2024
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Praveen-Brcm
approved these changes
Oct 25, 2024
rkavitha-hcl
pushed a commit
to rkavitha-hcl/sonic-buildimage
that referenced
this pull request
Nov 15, 2024
aidan-gallagher
pushed a commit
to aidan-gallagher/sonic-buildimage
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
PAC changes to receive config updates
How I did it
How to verify it