Adds YANG models for configurable intervals in CONFIG_DB for stormond #18657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assrinivasan
changed the title
assrinivasan
requested review from
saiarcot895,
vaibhavhd,
prgeor and
deepak-singhal0408
assrinivasan
force-pushed
the
storagemond-polling-interval-configdb
branch
from
db30e91 to
fc44000
Compare
ganglyu
reviewed
May 9, 2024
|
Please update doc/Configuration.md |
qiluo-msft
reviewed
May 14, 2024
wen587
reviewed
May 16, 2024
assrinivasan
changed the title
prgeor
previously approved these changes
May 17, 2024
qiluo-msft
previously approved these changes
May 20, 2024
Done |
|
Please update tests/files/sample_config_db.json |
assrinivasan
force-pushed
the
storagemond-polling-interval-configdb
branch
from
4fbbcdc to
cd23667
Compare
prgeor
approved these changes
May 21, 2024
|
@assrinivasan please fix the build and errors |
qiluo-msft
approved these changes
May 21, 2024
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This is part of a larger feature: SONiC Storage Monitoring Daemon -- this commit adds the option to configure the daemon's polling interval and fsstats file sync interval (in seconds) of the daemon via config_db by introducing YANG models.
Work item tracking
How I did it
Gives userside the option to dynamically a new table 'STORMOND' with key INTERVALS and fields 'daemon_polling_interval' with default value of '3600' seconds and 'fsstats_sync_interval' with default value of '86400' seconds as defined in the YANG model.
How to verify it
Flash image onto a DUT and add the aforementioned table to the CONFIG_DB. Verify that
stormondhas picked up your config intervals.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)