Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Enable CMIS host mgmt. feature to Mellanox-SN4700-O8C48, Mellanox-SN4700-O8V48 SKUs #18737

Merged
merged 1 commit into from
May 22, 2024

Conversation

noaOrMlnx
Copy link
Collaborator

@noaOrMlnx noaOrMlnx commented Apr 21, 2024

Why I did it

To enable CMIS host mgmt feature

Work item tracking
  • Microsoft ADO (number only):

How I did it

Update information on the relevant fields on each SKU

How to verify it

Load the system with the relevant SKU, verify CMIS host management is enabled, and per supported module check SW control is on.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Copy link
Collaborator

@keboliu keboliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also update the SAI profile

@keboliu
Copy link
Collaborator

keboliu commented Apr 30, 2024

and also please update the media_settings and optics_si_settings file.

@noaOrMlnx
Copy link
Collaborator Author

@keboliu
Feature in sai.profile is already enabled.
Regarding the media_settings.json update request, disucssed internally and found a solution. will apply soon

@noaOrMlnx
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@noaOrMlnx noaOrMlnx force-pushed the enable_cmis_host_mgmt branch from 21b79b9 to 61d891a Compare May 16, 2024 06:52
@noaOrMlnx
Copy link
Collaborator Author

/azpw run ms_conflict

@mssonicbld
Copy link
Collaborator

/AzurePipelines run ms_conflict

Copy link

No pipelines are associated with this pull request.

@noaOrMlnx
Copy link
Collaborator Author

Azure-Pipelines-Wrapper / ms_conflict

@noaOrMlnx
Copy link
Collaborator Author

/azpw ms_conflict

@noaOrMlnx
Copy link
Collaborator Author

/azpw ms_conflict

@noaOrMlnx noaOrMlnx force-pushed the enable_cmis_host_mgmt branch from 61d891a to c0c2d06 Compare May 20, 2024 06:56
@liat-grozovik liat-grozovik changed the title Enable CMIS host mgmt. feature to Mellanox-SN4700-O8C48, Mellanox-SN4700-O8V48 SKUs [Mellanox] Enable CMIS host mgmt. feature to Mellanox-SN4700-O8C48, Mellanox-SN4700-O8V48 SKUs May 22, 2024
@liat-grozovik liat-grozovik merged commit c2b0c7b into sonic-net:master May 22, 2024
19 checks passed
@noaOrMlnx
Copy link
Collaborator Author

@yxieca can you please cherry-pick to 202311?

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request May 23, 2024
…O8C48, Mellanox-SN4700-O8V48 SKUs (sonic-net#18737)

- Why I did it
To enable CMIS host mgmt feature

- How I did it
Update information on the relevant fields on each SKU

- How to verify it
Load the system with the relevant SKU, verify CMIS host management is enabled, and per supported module check SW control is on.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #19055

mssonicbld pushed a commit that referenced this pull request May 23, 2024
…O8C48, Mellanox-SN4700-O8V48 SKUs (#18737)

- Why I did it
To enable CMIS host mgmt feature

- How I did it
Update information on the relevant fields on each SKU

- How to verify it
Load the system with the relevant SKU, verify CMIS host management is enabled, and per supported module check SW control is on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants