[Mellanox] route config/set/delete performance improvement #18801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
approved these changes
Apr 25, 2024
liat-grozovik
changed the title
liat-grozovik
changed the title
|
can you provide the perf numbers? |
dprital
changed the title
liat-grozovik
approved these changes
Jun 6, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 11, 2024
…18801) - Why I did it Increase significantly the rate of routes config/set/delete to HW. - How I did it Add required flag in sai.profile and increase orchagent bulk size. - How to verify it Measure rate of route set/del operations at scale.
|
Cherry-pick PR to 202311: #19279 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 11, 2024
- Why I did it Increase significantly the rate of routes config/set/delete to HW. - How I did it Add required flag in sai.profile and increase orchagent bulk size. - How to verify it Measure rate of route set/del operations at scale.
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
|
@dprital Can you please confirm the change will not break warm-reboot on the old platforms? And please share the PR for the SAI change so that I can confirm the dependency has been cherry-picked. |
Hi @bingwang-ms , the change will not break warm-reboot on any platform. |
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…18801) - Why I did it Increase significantly the rate of routes config/set/delete to HW. - How I did it Add required flag in sai.profile and increase orchagent bulk size. - How to verify it Measure rate of route set/del operations at scale.
|
@bingwang-ms , This PR was approved for 202405. What is required to cherry pick it ? |
|
The automation should handle the cherry-pick. But it's not working somehow. @liushilongbuaa Could you please help check? |
bingwang-ms
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 31, 2024
…18801) - Why I did it Increase significantly the rate of routes config/set/delete to HW. - How I did it Add required flag in sai.profile and increase orchagent bulk size. - How to verify it Measure rate of route set/del operations at scale.
|
Cherry-pick PR to 202405: #19753 |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 31, 2024
- Why I did it Increase significantly the rate of routes config/set/delete to HW. - How I did it Add required flag in sai.profile and increase orchagent bulk size. - How to verify it Measure rate of route set/del operations at scale.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Increase significantly the rate of routes config/set/delete to HW.
Work item tracking
How I did it
Add required flag in sai.profile and increase orchagent bulk size.
How to verify it
Measure rate of route set/del operations at scale.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)