-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nokia-7215] Enhance Watchdog service #18850
[Nokia-7215] Enhance Watchdog service #18850
Conversation
platform/marvell/sonic-platform-nokia/7215/service/cpu_wdt.service
Outdated
Show resolved
Hide resolved
platform/marvell/sonic-platform-nokia/debian/sonic-platform-nokia-7215.postinst
Outdated
Show resolved
Hide resolved
f918bc9
to
f8adf12
Compare
f8adf12
to
9519679
Compare
@@ -9,6 +9,8 @@ systemctl restart kmod | |||
systemctl enable nokia-7215init.service | |||
systemctl start nokia-7215init.service | |||
|
|||
systemctl mask watchdog-control.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this guaranteed to happen before watchdog-control.service
starts? If there's a chance it could be after, then add --now
to have systemd stop the service as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified all scenarios to make sure there is no race condition - fresh install, software upgrade, reboots. The watchdog-control.service
is always masked correctly and the platform watchdog is active.
I have added the --now flag as recommended. I agree this is good to have in case something changes in the future
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
9519679
to
20af2dd
Compare
@bingwang-ms to tracking 202405 cherry-picking |
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
Cherry-pick PR to 202405: #19236 |
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
Mask Watchdog-control.service and make sure only one watchdog service starts on this platform
Why I did it
To resolve conflict between ordering of the 2 watchdog services.
Is some cases service 1 was started after service 2 leaving the watchdog on the box disabled
Work item tracking
How I did it
Enhance service file to assure cpu_wdt.service always starts after watchdog-control.service
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)