[UfiSpace][Bookworm][PDDF] Update UfiSpace platfrom codes to support bookworm and add new platforms support. #18936
Conversation
nonodark
force-pushed
the
local
branch
4 times, most recently
from
f8b7d65 to
60f3bbb
Compare
* s6301-56st * s7801-54xs * s8901-54xc * s9110-32x * s9300-32d
* s6301-56st * s7801-54xs * s8901-54dc * s9110-32x * s9300-32d
* s9301-32d * s9301-32db
|
@FuzailBrcm @Praveen-Brcm @adyeung @saiarcot895 please help review the change, thanks. |
|
@FuzailBrcm @Praveen-Brcm @adyeung @saiarcot895 please help review the change, thanks. |
|
@geans-pin , @leeprecy |
|
Sure.
…On Mon, May 20, 2024 at 9:16 PM FuzailBrcm ***@***.***> wrote:
@geans-pin <https://github.com/geans-pin> , @leeprecy
<https://github.com/leeprecy>
Can you guys also review?
—
Reply to this email directly, view it on GitHub
<#18936 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRWN4PJQODJVEBFFNVY6ZDZDLDBRAVCNFSM6AAAAABHP4YCPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRG4YDMNJTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Precy
--
This electronic communication and the information and any files transmitted
with it, or attached to it, are confidential and are intended solely for
the use of the individual or entity to whom it is addressed and may contain
information that is confidential, legally privileged, protected by privacy
laws, or otherwise restricted from disclosure to anyone else. If you are
not the intended recipient or the person responsible for delivering the
e-mail to the intended recipient, you are hereby notified that any use,
copying, distributing, dissemination, forwarding, printing, or copying of
this e-mail is strictly prohibited. If you received this e-mail in error,
please return the e-mail to the sender, delete it from your computer, and
destroy any printed copy of it.
|
|
@geans-pin @leeprecy @FuzailBrcm @Praveen-Brcm @adyeung @saiarcot895 please help review the change, thanks. |
| #include "../../../../pddf/i2c/modules/include/pddf_client_defs.h" | ||
| #include "../../../../pddf/i2c/modules/include/pddf_sysstatus_defs.h" | ||
|
|
||
| #define _memset(s, c, n) memset(s, c, n) |
There was a problem hiding this comment.
Why use _memset at all, instead of just using memset?
There was a problem hiding this comment.
A workaround to pass the Semgrep code check. Semgrep (old version) checks fail and recommend using the memset_s() function instead.
However, there is no memset_s() function in the kernel code. This code will not impact anything.
| return err; | ||
| } | ||
|
|
||
| #if LINUX_VERSION_CODE < KERNEL_VERSION(6, 1, 0) |
There was a problem hiding this comment.
For master branch, kernel modules won't be compiled with anything older than the 6.1 kernel, so I don't think the version check is needed here. Or is this code shared with other things?
There was a problem hiding this comment.
Yes, we want to share the same driver code across all SONiC branches and UfiSpace's internal projects.
|
@geans-pin @leeprecy @FuzailBrcm @Praveen-Brcm @adyeung please help review the change, thanks. |
* Fix the following conflicts - platform/broadcom/one-image.mk - platform/broadcom/rules.dep - platform/broadcom/rules.mk
|
@yxieca and @saiarcot895 , It seems that there is no more feedback. Could you help me merge the code? |
|
/azpw ms_conflict |
|
@yxieca , it seems that all checkers have passed and there is no more feedback. Could you help me merge the code? |
1 similar comment
|
@yxieca , it seems that all checkers have passed and there is no more feedback. Could you help me merge the code? |
…bookworm and add new platforms support. (sonic-net#18936) * Update old platform code. * s6301-56st * s7801-54xs * s8901-54xc * s9110-32x * s9300-32d * Update code to support Bookworm * s6301-56st * s7801-54xs * s8901-54dc * s9110-32x * s9300-32d * Add new ufispace platforms. * s9301-32d * s9301-32db * Update s9300-32d and s9301-32db bcm port config
…bookworm and add new platforms support. (sonic-net#18936) * Update old platform code. * s6301-56st * s7801-54xs * s8901-54xc * s9110-32x * s9300-32d * Update code to support Bookworm * s6301-56st * s7801-54xs * s8901-54dc * s9110-32x * s9300-32d * Add new ufispace platforms. * s9301-32d * s9301-32db * Update s9300-32d and s9301-32db bcm port config
Why I did it
Update UfiSpace platfrom codes to support bookworm on following Ufispace platforms.
Add PDDF support on following UfiSpace new platforms.
How I did it
How to verify it
Run pddf commands and show commands.
S6301-56ST
S7801-54XS
S8901-54XC
S9110-32X
S9300-32D
S9301-32D
S9301-32DB
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)