Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build bmp container into sonic-buildimage #18946

Merged
merged 49 commits into from
Nov 22, 2024
Merged

Build bmp container into sonic-buildimage #18946

merged 49 commits into from
Nov 22, 2024

Conversation

FengPan-Frank
Copy link
Contributor

@FengPan-Frank FengPan-Frank commented May 13, 2024 •
edited
Loading

Why I did it

Build bmp container into sonic-buildimage, and added relevant daemon/file handling.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Build bmp container into sonic-buildimage, and added relevant daemon/file handling.

How to verify it

Local build successfully and verified in lab DUT.

image image

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@FengPan-Frank FengPan-Frank requested review from qiluo-msft and removed request for qiluo-msft May 13, 2024 13:31
This was referenced May 13, 2024
Merged
Merged
@FengPan-Frank
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 18946 in repo sonic-net/sonic-buildimage

@FengPan-Frank
Copy link
Contributor Author

/azpw ms_conflict

qiluo-msft
qiluo-msft reviewed May 16, 2024
View reviewed changes
rules/config Outdated Show resolved Hide resolved
@lguohan lguohan added the BMP Bgp Monitor Container label May 18, 2024
@forrestchu
Copy link

Why I did it

Add bmp container init workflow.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Add bmp container which is disabled by INCLUDE_BMP = n for now, which would cause container not build by default. This will be enabled as last step.

Add INCLUDE_BMP to indicate whether to build bmp container Add docker file for bmp, as well as agent used openbmpd/bmpcfgd. Add template file for bmp container services. Add entry for bmp to FEATURE table in config_db.

How to verify it

Build image with INCLUDE_BMP = y to verify, Image should be install correctly. By config feature state bmp enabled to enable.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Hi Frank, which TCP port will this bmp server use by default? Is it configurable from config_db or CLI?

@FengPan-Frank
Copy link
Contributor Author

FengPan-Frank commented Nov 7, 2024 •
edited
Loading

Why I did it

Add bmp container init workflow.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Add bmp container which is disabled by INCLUDE_BMP = n for now, which would cause container not build by default. This will be enabled as last step.
Add INCLUDE_BMP to indicate whether to build bmp container Add docker file for bmp, as well as agent used openbmpd/bmpcfgd. Add template file for bmp container services. Add entry for bmp to FEATURE table in config_db.

How to verify it

Build image with INCLUDE_BMP = y to verify, Image should be install correctly. By config feature state bmp enabled to enable.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • [ ]
  • [ ]

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Hi Frank, which TCP port will this bmp server use by default? Is it configurable from config_db or CLI?

it's 5000, pls refer HLD section https://github.com/sonic-net/SONiC/blob/50cb55989649d5392b48b54bb7ca8263c883e162/doc/bmp/bmp.md#config-file-update

@FengPan-Frank FengPan-Frank changed the title Add bmp container init workflow. Build bmp container into sonic-buildimage Nov 19, 2024
@FengPan-Frank
fix submodule
fdecfb0
@FengPan-Frank
Merge branch 'sonic-net:master' into bmp_init
22ad972
@FengPan-Frank
skip bmpcfgd test temporarily
808f8c0
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
d1c3e10 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
cd6af6f 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
9d8b842 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
b48c9a4 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
676b867 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
b13fe8e 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
0f9b171 
…ldimage into bmp_init
@FengPan-Frank
Launch bmp container by default
f140130
@FengPan-Frank
Merge branch 'sonic-net:master' into bmp_init
c70e767
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
d92aaca 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
d17acb2 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
45d9fff 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
cfc4d2b 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
c3db6bd 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
6841079 
…ldimage into bmp_init
@FengPan-Frank
Merge branch 'bmp_init' of https://github.com/FengPan-Frank/sonic-bui…
47bb5b6 
…ldimage into bmp_init
FengPan-Frank
FengPan-Frank commented Nov 21, 2024
View reviewed changes
Copy link
Contributor Author

@FengPan-Frank FengPan-Frank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonic-net/sonic-host-services#128, bmpcfgd unittest passed in sonic-host-services before.

@qiluo-msft qiluo-msft merged commit f8a78c1 into sonic-net:master Nov 22, 2024
22 checks passed
@mlok-nokia mlok-nokia mentioned this pull request Dec 1, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@xincunli-sonic xincunli-sonic xincunli-sonic approved these changes

@xumia xumia Awaiting requested review from xumia xumia is a code owner

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
BMP Bgp Monitor Container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FengPan-Frank @forrestchu @qiluo-msft @xincunli-sonic @lguohan