Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Buffer pool enum type both for sonic chassis #18956

Merged
merged 2 commits into from
May 23, 2024

Conversation

vmittal-msft
Copy link
Contributor

Why I did it

Added buffer pool type as both for yang model verification

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vmittal-msft vmittal-msft requested a review from qiluo-msft as a code owner May 13, 2024 23:09
@vmittal-msft vmittal-msft added the Chassis 🤖 Modular chassis support label May 13, 2024
@lguohan lguohan added the YANG YANG model related changes label May 17, 2024
Copy link
Contributor

@xincunli-sonic xincunli-sonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vmittal-msft vmittal-msft requested a review from arlakshm May 22, 2024 22:56
@vmittal-msft
Copy link
Contributor Author

@qiluo-msft @xincunli-sonic Can you please help merge this ?

@lguohan lguohan merged commit e240bc7 into sonic-net:master May 23, 2024
20 checks passed
@vmittal-msft vmittal-msft deleted the vmittal/master-yang branch May 23, 2024 21:21
@gechiang gechiang added Chassis for 202205 branch PRs needed for 202205 branch in msft repo and removed Request for 202205 Branch Request for 202305 Branch labels Jun 4, 2024
@gechiang gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Jun 4, 2024
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
[yang]: adding Buffer pool enum type both for sonic chassis (sonic-net#18956)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chassis for 202205 branch PRs needed for 202205 branch in msft repo Chassis 🤖 Modular chassis support Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch YANG YANG model related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants