Fix docker-wait-any script crash issue #19009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix docker-wait-any script crash issue.
Why I did it
docker-wait-any script will create a waiting thread for multiple containers.
When any container thread exit, g_thread_exit_event will set, and main thread will exit.
However when this happen, some thread may still waiting container with following code:
docker_client.wait(container_name)
Because docker_client will be destroyed when main thread exist, some time wait method will throw TypeError, and this will cause swss.sh crash then swss container can't start:
<30>May 13 07:11:22 DEVICE_NAME swss.sh[13603]: Traceback (most recent call last):
<30>May 13 07:11:22 DEVICE_NAME swss.sh[13603]: Exception in thread Thread-1:
...
<30>May 13 07:11:22 DEVICE_NAME swss.sh[13603]: while docker_client.inspect_container(container_name)['State']['Status'] != "running":
...
<30>May 13 07:11:23 DEVICE_NAME swss.sh[13603]: TypeError: 'NoneType' object is not callable
<13>May 13 07:11:23 DEVICE_NAME root: Stopping swss service...
This PR is based on analyze result of following PR: #10812
Work item tracking
How I did it
Ignore TypeError and exit current wait thread when g_thread_exit_event set.
How to verify it
Pass all UT.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Fix docker-wait-any script crash issue.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)