Revert suppress FIB pending feature #19027
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This reverts commit 183ee7d.
| @@ -212,18 +212,6 @@ module sonic-device_metadata { | |||
| By default SONiC advertises /128 subnet prefix in Loopback0 as /64 subnet route"; | |||
| } | |||
|
|
|||
| leaf suppress-fib-pending { | |||
There was a problem hiding this comment.
i suggest to keep these yang model instead of simple reverting.
There was a problem hiding this comment.
@lguohan I don't want to keep CLI and YANG model for a feature that does not work in a release
|
/azpw run |
|
/AzurePipelines run |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lguohan how do you want to followup on that? |
|
/azpw ms_conflict |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw ms_conflict -f |
|
/azpw ms_conflict |
|
hi @stepanblyschak I think we also need this for 202405, could you help to run a test before we do the cherry pick for 202405? @bingwang-ms for vis. |
|
@StormLiangMS This PR was targeting 202405 originally |
|
@bingwang-ms Please cherry-pick this PR for 202405 |
Why I did it Revert BGP suppress FIB pending due to unresolved FRR issues in current version Work item tracking Microsoft ADO (number only): How I did it Revert it How to verify it Build and run
|
@bingwang-ms Can you please check why PR for 202405 is not created? |
liushilongbuaa
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
Why I did it Revert BGP suppress FIB pending due to unresolved FRR issues in current version Work item tracking Microsoft ADO (number only): How I did it Revert it How to verify it Build and run
|
Cherry-pick PR to 202405: #19736 |
I checked the logs. But I don't find the reason. |
Why I did it Revert BGP suppress FIB pending due to unresolved FRR issues in current version Work item tracking Microsoft ADO (number only): How I did it Revert it How to verify it Build and run
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Why I did it Revert BGP suppress FIB pending due to unresolved FRR issues in current version Work item tracking Microsoft ADO (number only): How I did it Revert it How to verify it Build and run
This reverts commit 4397a85.
…-net#19836) Reverts sonic-net#19027 The support for BGP zebra enhancements is merged in sonic-net#19717. Hence re-enabling BGP suppress fib pending feature.
Why I did it
Revert BGP suppress FIB pending due to unresolved FRR issues in current version
Work item tracking
How I did it
Revert it
How to verify it
Build and run
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)