[action] [PR:18791] [Mellanox][SN4410] Add missing interfaces to hwsku (#18791) #19033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Why I did it Logic of config generation changed recently Command : sonic-cfggen -H -k ACS-MSN4410 --preset t1 will fail after ONIE installation. There are missing interfaces for 4410 HWSKU. Need to add them. - How I did it Update file device/mellanox/x86_64-mlnx_msn4410-r0/ACS-MSN4410/hwsku.json - How to verify it sonic-cfggen -H -k ACS-MSN4410 --preset t1 will pass successfully on 4410 platform after ONIE installation. Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
|
Original PR: #18791 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Logic of config generation changed recently
Command : sonic-cfggen -H -k ACS-MSN4410 --preset t1 will fail after ONIE installation.
There are missing interfaces for 4410 HWSKU. Need to add them.
How I did it
Update file device/mellanox/x86_64-mlnx_msn4410-r0/ACS-MSN4410/hwsku.json
How to verify it
sonic-cfggen -H -k ACS-MSN4410 --preset t1 will pass successfully on 4410 platform after ONIE installation.
Signed-off-by: Andriy Yurkiv ayurkiv@nvidia.com