Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRR] enable snmp trap support #3354

Open
wants to merge 3 commits into
base: 201904
Choose a base branch
from

Conversation

batmancn
Copy link

@batmancn batmancn commented Aug 16, 2019

**- What I did **

This PR brings the functionality of being able to handle BGP traps in sonic-frr. This PR based on #2981
For detail of how to use, I give a demo that use BGP traps to track BGP peer status, and set into APPL_DB.

**- How to verify **

I test my demo like this:

  1. use this PR, and demo PR
  2. create BGP peer
  3. up/down BGP peer, and check syslog
# router bgp 65003
# neighbor 192.168.10.9 shutdown
# no neighbor 192.168.10.9 shutdown

Aug 16 04:42:03.483442 ... INFO snmp#bgp-peer-status: [bgp-peer-status] setDbPeerStatus: key = BGP_NEIGHBOR:192.168.10.9, status = Idel
Aug 16 04:45:59.367653 ... INFO snmp#bgp-peer-status: [bgp-peer-status] setDbPeerStatus: key = BGP_NEIGHBOR:192.168.10.9, status = Established

MichelMoriniaux and others added 3 commits August 6, 2019 16:14
This is a follow-up of sonic-snmpagent PR 92
Now that licensing issues have been solved FRR is distributed with SNMP
support compiled-in. This PR adds the last bits of configuration to get
the frr-snmp debian packages added to the docker container and the
config bits to enable the snmp module in FRR

This PR brings the functionality of being able to poll bgpd for routes
and peer status.

Signed-off-by: Michel Moriniaux <m.moriniaux@criteo.com>
This is a follow-up of sonic-snmpagent PR 92
Now that licensing issues have been solved FRR is distributed with SNMP
support compiled-in. This PR adds the last bits of configuration to get
the frr-snmp debian packages added to the docker container and the
config bits to enable the snmp module in FRR

This PR brings the functionality of being able to poll bgpd for routes
and peer status.

Signed-off-by: Michel Moriniaux <m.moriniaux@criteo.com>
Codes brings the functionality of being able to handle BGP traps
@batmancn batmancn changed the title Feature/enable snmp trap support [FRR] enable snmp trap support Aug 16, 2019
@pavel-shirshov pavel-shirshov self-requested a review October 15, 2019 18:58
@pavel-shirshov pavel-shirshov self-assigned this Oct 15, 2019
@qiluo-msft
Copy link
Collaborator

qiluo-msft commented Nov 18, 2019

If this is a new feature, please submit to master branch first. We will cherry-pick to old release branch if necessary.

# All lines beginning with a '#' are comments and are intended for you
# to read. All other lines are configuration commands for the agent.

disableAuthorization yes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it dangerous to disable auth?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants