-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read fan_fault=1 and send log when fan insert sometimes #4106
Open
jostar-yang
wants to merge
24
commits into
sonic-net:master
Choose a base branch
from
jostar-yang:20200204_fan_fault
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retest please |
jostar-yang
force-pushed
the
20200204_fan_fault
branch
from
April 12, 2021 05:59
b9683e8
to
e6686d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix read fan_fault=1 and send log when fan insert sometimes
- How I did it
Add check fan_fault when fan_status=fan_fault . If fan_fault become to zero, log "FAN-N becomes operational"
- How to verify it
Run monitor_fan.py. Remove fan from DUT. Insert fan to DUT. Check log as below,
root : INFO FAN-6 present is detected
root : WARNING Alarm for FAN-6 failed is detected
root : INFO FAN-6 becomes operational
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)