-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cameo platform ESC601-32Q #5057
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
retest vsimage please |
@@ -0,0 +1,847 @@ | |||
/* | |||
* at24.c - handle most I2C EEPROMs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the at24.c which is part of the Linux kernel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intel I801 works on SMBus mode. We are using "24c64"(16bit address) for system eeprom.
in at24.c:
if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
if (chip.flags & AT24_FLAG_ADDR16)
return -EPFNOSUPPORT;
So, we made a modification in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any further comment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lguohan to comment.
@@ -0,0 +1,432 @@ | |||
/* | |||
* mcp3422.c - driver for the Microchip mcp3421/2/3/4/5/6/7/8 chip family |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the mcp3422.c which is part of the Linux kernel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of I2C bus controller is only SMbus(I801) mode on our board. In mcp3422 linux native driver will call "i2c_check_functionality" and return "EOPNOTSUPP", so we do a work around in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mcp3425_smbus.c is based on Linux mcp3422.c to fit our dedicated SMbus requirement. Any further comment on this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lguohan to comment.
platform/innovium/sonic-platform-modules-cameo/esc601-32q/modules/pmbus.h
Outdated
Show resolved
Hide resolved
platform/innovium/sonic-platform-modules-cameo/esc601-32q/utils/cameo_esc601_util.py
Outdated
Show resolved
Hide resolved
platform/innovium/sonic-platform-modules-cameo/esc601-32q/utils/halt
Outdated
Show resolved
Hide resolved
platform/innovium/sonic-platform-modules-cameo/esc601-32q/utils/halt
Outdated
Show resolved
Hide resolved
platform/innovium/sonic-platform-modules-cameo/esc601-32q/utils/poweroff
Outdated
Show resolved
Hide resolved
platform/innovium/sonic-platform-modules-cameo/esc601-32q/utils/poweroff
Outdated
Show resolved
Hide resolved
platform/innovium/sonic-platform-modules-cameo/esc601-32q/utils/shutdown
Outdated
Show resolved
Hide resolved
platform/innovium/sonic-platform-modules-cameo/esc601-32q/utils/shutdown
Outdated
Show resolved
Hide resolved
I don't understand the meaning to test with vsimage. As we know, the vs is a Virtual Switch independent from any platform/device, but the platform driver is dedicated to our device. Furthermore, we also followed the "platform test plan" to verify the driver package with SONiC. Please kind advise the purpose and the test cases to be processed. Thanks. |
@maxliu37: That comment wasn't directed at you. By entering the phrase "retest this please" into a comment, GitHub triggers our Jenkins server to re-run all of the check builds, and "retest <test_name> please" will trigger a specific check build to re-run. |
Thanks for the clarification. This is our first merge request, not knowing well on all activities. |
Retest vsimage please |
This pull request introduces 13 alerts when merging 9a5be5627a4eb6d341840d03b9cfe668d3bc71cc into 895f4e0 - view on LGTM.com new alerts:
|
Switch Vendor: Cameo
Switch SKU: ESC601-32Q
CPU: BROADWELL-DE
ASIC Vendor: Innovium
Switch ASIC: TL7
Port Configuration: 32x200G
- Which release branch to backport (provide reason below if seleted)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)