Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cameo platform ESC601-32Q #5057

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Cameo platform ESC601-32Q #5057

wants to merge 4 commits into from

Conversation

Hanly-Cameo
Copy link

@Hanly-Cameo Hanly-Cameo commented Jul 28, 2020

Switch Vendor: Cameo
Switch SKU: ESC601-32Q
CPU: BROADWELL-DE
ASIC Vendor: Innovium
Switch ASIC: TL7
Port Configuration: 32x200G

What I did
Add a new Cameo platform ESC601-32Q.

How I did it
Add files by following SONiC Porting Guide.

How to verify it
a)with "make target/sonic-innovium.bin"
b)install image and check the following commands
decode-syseeprom
sensors
psuutil
sfputil

- Which release branch to backport (provide reason below if seleted)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lgtm-com

This comment has been minimized.

@lguohan
Copy link
Collaborator

lguohan commented Aug 3, 2020

retest vsimage please

@@ -0,0 +1,847 @@
/*
* at24.c - handle most I2C EEPROMs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the at24.c which is part of the Linux kernel?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel I801 works on SMBus mode. We are using "24c64"(16bit address) for system eeprom.
in at24.c:

	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
		if (chip.flags & AT24_FLAG_ADDR16)
			return -EPFNOSUPPORT;

So, we made a modification in it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any further comment ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan to comment.

@@ -0,0 +1,432 @@
/*
* mcp3422.c - driver for the Microchip mcp3421/2/3/4/5/6/7/8 chip family
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the mcp3422.c which is part of the Linux kernel?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of I2C bus controller is only SMbus(I801) mode on our board. In mcp3422 linux native driver will call "i2c_check_functionality" and return "EOPNOTSUPP", so we do a work around in it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mcp3425_smbus.c is based on Linux mcp3422.c to fit our dedicated SMbus requirement. Any further comment on this issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lguohan to comment.

@maxliu37
Copy link

retest vsimage please

I don't understand the meaning to test with vsimage. As we know, the vs is a Virtual Switch independent from any platform/device, but the platform driver is dedicated to our device. Furthermore, we also followed the "platform test plan" to verify the driver package with SONiC. Please kind advise the purpose and the test cases to be processed. Thanks.

@jleveque
Copy link
Contributor

jleveque commented Aug 11, 2020

@maxliu37: That comment wasn't directed at you. By entering the phrase "retest this please" into a comment, GitHub triggers our Jenkins server to re-run all of the check builds, and "retest <test_name> please" will trigger a specific check build to re-run.

@maxliu37
Copy link

@maxliu37: That comment wasn't directed at you. By entering the phrase "retest this please" into a comment, GitHub triggers our Jenkins server to re-run all of the check builds, and "retest <test_name> please" will trigger a specific check build to re-run.

Thanks for the clarification. This is our first merge request, not knowing well on all activities.

@jleveque
Copy link
Contributor

Retest vsimage please

@jleveque jleveque requested a review from lguohan August 13, 2020 17:49
@lgtm-com
Copy link

lgtm-com bot commented Oct 8, 2020

This pull request introduces 13 alerts when merging 9a5be5627a4eb6d341840d03b9cfe668d3bc71cc into 895f4e0 - view on LGTM.com

new alerts:

  • 6 for Unused local variable
  • 4 for Variable defined multiple times
  • 2 for Use of the return value of a procedure
  • 1 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants