Remove sorting from qos_config.j2 #5505
Conversation
The sort Function on Portname is not able to understand Backplance Interface name. Fix is to to remove sorting from j2 template as this is not needed as all Ports are dervice port_config.ini where ports are listed in fixed static sort order. Also we do not sort port in buffer_config.j2 so made logic similar to that and keep it simple instead of enhancing sort function. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
Can you add more info about where is it breaking. This change is there in both master and 201911. https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-config-engine/sonic-cfggen#L58 @smaheshm thanks for pointing out that was git merge issue that caused this. Things are fine now. However I still feel this is good change to have as it remove dependency on updating sort function with any new alias Please review |
|
retest broadcom please |
2 similar comments
|
retest broadcom please |
|
retest broadcom please |
abdosi
changed the title
|
retest broadcom please |
|
@abdosi Is this still relevant? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@abdosi Can you also update sonic-cfggen to remove the sort_by_index. This change is required for chassis. |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run 1 |
|
No pipelines are associated with this pull request. |
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
can you also remove the API from sonic-cfggen |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Why I did:
Optimize not use use use sort function as if interface name changes we need to update sort function.
Also this is not needed as all Ports are derive from port_config.ini where ports are listed
in fixed static sort order.
Also we do not sort port in buffer_config.j2 so made logic similar to
that and keep it simple instead of enhancing sort function.
How I did:
Fix is to to remove sorting from j2 template as this is not needed
How I verified:
config load_minigraph -y is fine which internally invoke config qos reload.