-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Host Account Management (HAM) project #5553
base: master
Are you sure you want to change the base?
Conversation
The new guidelines as I understand is to associate test with every new code to be checked in. This is indeed a big new code for a new feature. What is the plan for tests? |
Hi @renukamanavalan , Agreed, tests for HAM need to be added. I will find some time to add a test framework for HAM (hopefully soon). By the way, are there any test guidelines? I assume tests are run in a VM? In other words, if a test fails in such a way that it leaves the system in a wonky state, it's only the test VM that will be affected. Any pointers would be greatly appreciated. NOTE: Currently, hamd is not used by anything. In other words, the risk level is very low. Regardless, I will start working on tests as soon as I can. Regards, |
…n add that on a second merge request. We just want to run more tests first.
Manually resolved conflicts
…nges to APIs in swss-common.
$(HAM)_DEPENDS = $(LIBSWSSCOMMON_DEV) | ||
$(HAM)_RDEPENDS = $(LIBSWSSCOMMON) | ||
|
||
SONIC_DPKG_DEBS += $(HAM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this conditional include using a build time flag?
Hi, |
- Dependencies
It wasn't clear how to put a dependency between two pull requests, hence I added this section.
This pull request depends on sonic-swss-common #390 being merged first.
- Why I did it
As described in AAA Improvements, there is a need for a central location to manage user accounts. The solution is "Host Account Management" or HAM, which acts as the single source of truth for user accounts. Some of the features of HAM include:
- How I did it
Not sure what "How I did it" means. I wrote C/C++ code?
For a description of how to use HAM, refer to the src/ham/README.md.
- How to verify it
This pull request adds a new building block called HAM. In this pull request we do not hook HAM up to any other components in SONiC. In a second phase, we will hook up RADIUS/TACACS+ to use HAM. In a third phase, the sonic-management-framework will also use HAM. Since HAM is not hooked up to anything in this first phase, the only way to verify that things are in place is through the debug utility "
hamctl
". This can be invoked at the bash shell.- Which release branch to backport (provide reason below if selected)
No backport needed. This is a new feature.
- Description for the changelog
New Host Account Management feature. A detailed description of HAM can be found in: https://github.com/Azure/SONiC/blob/master/doc/aaa/AAA%20Improvements/AAA%20Improvements.md