[MCLAG] Fix the bug of iccp FDB synchronization #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dongjianjun@inspur.com
Why I did it
The method of ICCP reading FDB table entries from ASIC DB is optimized.
When more than 1400 MACs was notified to iccpd at the same time, the buffer size (65535) of the data read by iccpd will be exceeded, causing iccpd to read incomplete messages and an exception occurred.
How I did it
When iccpd reads MAC information, it first reads the length of the message from the message header, and then reads the data information of the message according to the length, so that each time it reads a complete message. In order to avoid falling into dead loop or occupying CPU for a long time, iccpd can read up to 20 packets (more than 1700 MACs) at a time. If more than 1700 MACs, it will read the remaining MAC next time.
How to verify it
Test on the switch.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)