Correct the variable name of policies.conf.j2 template #7713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gord1306
force-pushed
the
bgpd_policies_conf_j2
branch
from
e5bb294 to
a150987
Compare
|
/azpw run |
|
Commenter does not have sufficient privileges for PR 7713 in repo Azure/sonic-buildimage |
gord1306
force-pushed
the
bgpd_policies_conf_j2
branch
from
a150987 to
f030f66
Compare
|
/azpw run |
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
…tion variable name
should be constants.bgp.allow_list.default_action instead of allow_list_default_action
```
constants:
bgp:
allow_list:
default_action: deny
... skip ...
```
Signed-off-by: Gord Chen <gord_chen@edge-core.com>
gord1306
force-pushed
the
bgpd_policies_conf_j2
branch
from
f030f66 to
0364a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Verify the sonic-mgmt test_bgp_allow_list.py (the commit base is f9ada0db) and the TestBGPAllowListDeny::test_empty_allow_list_deny was failed
How I did it
Correct the variable name of policies.conf.j2 template
According to the contenet of /etc/sonic/constants.yml, the default action variable name
should be
constants.bgp.allow_list.default_actioninstead ofallow_list_default_actionHow to verify it
Verify by the sonic-mgmt and sonic-bgpcfgd unit test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)