[Juniper] Migrating to SONiC Platform API package #8257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch set introduce platform API package for QFX5210 & QFX5200 platforms Signed-off-by: Ciju Rajan K <crajank@juniper.net>
|
This pull request introduces 27 alerts and fixes 4 when merging 9283eed into 5e435e0 - view on LGTM.com new alerts:
fixed alerts:
|
|
@jleveque Could you help me to understand what is wrong with the constructor calls? Lgtm issues the warning "17 for Wrong number of arguments in a class instantiation". I tried to suppress it, but still the warnings are mentioned in the summary. There are not any warnings shown in the lgtm code view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set introduce platform API package for QFX5210 & QFX5200 platforms
Signed-off-by: Ciju Rajan K crajank@juniper.net
This is the follow-up pull request from #8074