Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AS4630-54TE] Fix psu drv to support YM1151D PSU #8638

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jostar-yang
Copy link
Contributor

Signed-off-by: Jostar Yang jostar_yang@accton.com.tw

Why I did it

Fix psu drv to support YM1151D PSU.

How I did it

  1. Modify code to read model_name and remove not needed words.
  2. Modify to read serial number from 0x2e instead of 0x35

How to verify it

Test sysfs.
#cat psu_serial_number
SA060P152025000821

cat psu_model_name

YM-1151D

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
    -->Please merge to this branch
  • 202106
    -->Please merge to this branch

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
@jostar-yang jostar-yang requested a review from lguohan as a code owner August 31, 2021 08:59
@seanwu-ec seanwu-ec mentioned this pull request Dec 28, 2021
5 tasks
@matofeder
Copy link

@jostar-yang I tested the change and it seems that I got the wrong direction of PSU FAN, even though the change looks correct from my point of view.

See switch and psu types below:

# show platform syseeprom 
TlvInfo Header:
   Id String:    TlvInfo
   Version:      1
   Total Length: 177
TLV Name             Code      Len  Value
-------------------  ------  -----  ----------------------------
Product Name         0x21       18  AS4630-54TE-O-AC-B
Part Number          0x22       13  F0PZZ4654045A
Serial Number        0x23       15  463054TE2315114
Base MAC Address     0x24        6  D0:77:CE:2B:59:C4
Manufacture Date     0x25       19  04/17/2023 11:06:45
Label Revision       0x27        4  R01F
Platform Name        0x28       28  x86_64-accton_as4630_54te-r0
ONIE Version         0x29       13  2020.08.00.11
MAC Addresses        0x2A        2  256
Manufacturer         0x2B        6  Accton
Manufacture Country  0x2C        2  TW
Vendor Name          0x2D        8  Edgecore
Diag Version         0x2E       11  01.01.02.02
CRC-32               0xFE        4  0x8799A7C4
 show platform psu
PSU    Model          Serial             HW Rev      Voltage (V)    Current (A)    Power (W)  Status    LED
-----  -------------  -----------------  --------  -------------  -------------  -----------  --------  -----
PSU 1  YM-1151D-A02R  SA080P14230900580  N/A               11.98           2.00        23.00  OK        green
PSU 2  YM-1151D-A02R  SA080P14230900579  N/A               12.05           2.23        26.00  OK        green

According to https://www.edge-core.com/wp-content/uploads/2023/08/EPS201-AS4630-54TE-DS-R04.pdf, both AS4630-54TE-O-AC-B and YM-1151D-A02R should have B2F airflow.

But show platform fan and system-health report different fan directions for psu, see:

# show platform fan
  Drawer    LED          FAN    Speed    Direction    Presence    Status          Timestamp
--------  -----  -----------  -------  -----------  ----------  --------  -----------------
FanTray1  green        FAN-1      50%       intake     Present        OK  20241010 08:28:19
FanTray2  green        FAN-2      50%       intake     Present        OK  20241010 08:28:19
FanTray3  green        FAN-3      50%       intake     Present        OK  20241010 08:28:19
     N/A    N/A  PSU-1 FAN-1      35%      exhaust     Present        OK  20241010 08:28:24
     N/A    N/A  PSU-2 FAN-1      32%      exhaust     Present        OK  20241010 08:28:27
# show system-health summary 
System status summary

  System status LED  STATUS_LED_COLOR_AMBER
  Services:
    Status: OK
  Hardware:
    Status: Not OK
    Reasons: PSU-2 FAN-1 direction exhaust is not aligned with FAN-1 direction intake
             PSU-1 FAN-1 direction exhaust is not aligned with FAN-1 direction intake

Have you any idea why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants