Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Celestica/sonic_platform]: Fixed failed test cases in Seastone-DX010 platform testing. #8729

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Sep 10, 2021

Why I did it

  • To fixed failed test cases in Seastone-DX010 platform testing.

How I did it

  • Enable the SMBus access to QSFP/SFP module. Allow the data to be written to the module's EEPROM.
  • Define the maximum power drawn by Fan Drawer for fan's API

How to verify it

  • Run platform test on testbed

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Wirut Getbamrung and others added 2 commits September 9, 2021 13:12
* [platform/Seastone] Improve XCVR I2C driver

- Add support to following SMBus transactions
   * SMBus Receive Byte
   * SMBus Read/Write Byte
   * SMBus Read/Write Word
- SMBus core code refactoring.
- Add dynamic print debug message.

* checkpatch: use device related debug print

* code style: apply Linux kernel code style

* checkpatch: use _store/_show for sysfs access
@lgtm-com
Copy link

lgtm-com bot commented Sep 10, 2021

This pull request introduces 5 alerts when merging 446a67c into f899a82 - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'

@mudsut4ke mudsut4ke marked this pull request as ready for review September 22, 2021 07:13
@mudsut4ke mudsut4ke requested a review from lguohan as a code owner September 22, 2021 07:13
@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2021

This pull request introduces 6 alerts when merging d5ebd8d into a61ffcd - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'
  • 1 for Unused import

@Blueve
Copy link
Contributor

Blueve commented Nov 17, 2021

This pull request introduces 6 alerts when merging d5ebd8d into a61ffcd - view on LGTM.com

new alerts:

  • 5 for Except block handles 'BaseException'
  • 1 for Unused import

@mudsut4ke could you address these alert? Why use BaseException replace IOException?

@mudsut4ke
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@Blueve
Copy link
Contributor

Blueve commented Jan 18, 2022

/azp help

@azure-pipelines
Copy link

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@Blueve
Copy link
Contributor

Blueve commented Jan 18, 2022

/azp list

@Blueve
Copy link
Contributor

Blueve commented Jan 18, 2022

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mudsut4ke mudsut4ke requested a review from a team as a code owner June 10, 2022 02:01
@lguohan lguohan added the device label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants