[yang-model] Using 'leafref' instead of 'must' for loopback #9535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghooo
force-pushed
the
dev/mghoneim/lo_leafref
branch
from
b83699f to
1de5394
Compare
qiluo-msft
reviewed
Dec 14, 2021
src/sonic-yang-models/tests/yang_model_tests/tests/loopback.json
Outdated
Show resolved
Hide resolved
qiluo-msft
requested review from
rathnasabapathyv,
praveen-li,
ganglyu and
qiluo-msft
qiluo-msft
approved these changes
Dec 15, 2021
praveen-li
reviewed
Dec 15, 2021
| description "Loopback interface name"; | ||
|
|
||
| type leafref { | ||
| path "../../LOOPBACK_INTERFACE_LIST/name"; |
There was a problem hiding this comment.
Lets keep error-msg, something as below:
error-message "Loopback VRF interface must exist, Try adding lo<>: {}, Example: 'lo1': {}";
description "Loopback interface name";
There was a problem hiding this comment.
plz see if we must do similar changes in VLAN_INTERFACE and in INTERFACE. Thx
There was a problem hiding this comment.
I haven't seen error-message used with leafref before in any sonic yang models. I think it is not supported:
libyang[0]: Invalid keyword "error-message". (path: /sonic-loopback-interface:sonic-loopback-interface/LOOPBACK_INTERFACE/LOOPBACK_INTERFACE_IPPREFIX_LIST/name)
Tried like this:
leaf name{
error-message "Loopback VRF interface must exist, Try adding lo<>: {}, Example: 'lo1': {}";
description "Loopback interface name";
type leafref {
path "../../LOOPBACK_INTERFACE_LIST/name";
}
}
and this:
leaf name{
description "Loopback interface name";
type leafref {
error-message "Loopback VRF interface must exist, Try adding lo<>: {}, Example: 'lo1': {}";
path "../../LOOPBACK_INTERFACE_LIST/name";
}
}
There was a problem hiding this comment.
plz see if we must do similar changes in VLAN_INTERFACE and in INTERFACE. Thx
Yes, we might need to fix these as well. I will start first by checking if we can can the referrers from must statements #9534
ganglyu
approved these changes
Dec 15, 2021
qiluo-msft
added
Request for 202111 Branch
judyjoseph
pushed a commit
that referenced
this pull request
Jan 9, 2022
#### Why I did it Fix issue sonic-net/sonic-utilities#1962 The problem is current implementation of [sonic-yang-mgmt::find_data_dependencies](https://github.com/Azure/sonic-buildimage/blob/f2774b635dee2d5c0e30489632b47e0210a712dd/src/sonic-yang-mgmt/sonic_yang.py#L518) does not get referrers if they are using `must` statement, it has to use `leafref`. For now we can convert `must` to `leafref` if possible. In the future we will investigate get referrers by `must` statements as well #9534 #### How I did it Instead of `must` use `leafref` #### How to verify it unit-test #### Which release branch to backport (provide reason below if selected) - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix issue sonic-net/sonic-utilities#1962
The problem is current implementation of sonic-yang-mgmt::find_data_dependencies does not get referrers if they are using
muststatement, it has to useleafref.For now we can convert
musttoleafrefif possible. In the future we will investigate get referrers bymuststatements as well #9534How I did it
Instead of
mustuseleafrefHow to verify it
unit-test
Which release branch to backport (provide reason below if selected)