Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yang] Fixing groupings when grouping is in the same module file #9880

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

ghooo
Copy link
Contributor

@ghooo ghooo commented Jan 28, 2022

Why I did it

If the grouping is in the same file in the module, fetching the grouping fails

How I did it

fixing the uses_module_name when the grouping is under the same file

How to verify it

Enabled a grouping under the same file which is lldp, there is a test in sonic-yang-mgmt that translates sample-config-db into yang format. This test passes with grouping in lldp used.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@ghooo ghooo requested review from praveen-li and qiluo-msft and removed request for lguohan and qiluo-msft January 28, 2022 07:52
Copy link
Member

@praveen-li praveen-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghooo ghooo merged commit f8fd2de into sonic-net:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants