Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marvell Arm64 and armada 7020 #124

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antony-rheneus
Copy link
Contributor

Marvell Armada A7020 support backported to 4.9.189
Arm64 PCI mmap resource from user space using sysfs
Arm64 /proc/dma file access

Signed-off-by: Antony Rheneus arheneus@marvell.com

Arm64 PCI mmap resource from user space using sysfs
Arm64 /proc/dma file access

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Arm64 PCI mmap resource from user space using sysfs
Arm64 /proc/dma file access

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@antony-rheneus
Copy link
Contributor Author

Please retry compilation, as it got failed as below.

LD [M] drivers/net/wireless/realtek/rtlwifi/rtl8723be/rtl8723be.o
LD drivers/net/wireless/built-in.o
LD drivers/net/built-in.o
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/Makefile:1026: recipe for target 'drivers' failed
make[5]: *** [drivers] Error 2
Makefile:152: recipe for target 'sub-make' failed
make[4]: *** [sub-make] Error 2
Makefile:24: recipe for target '__sub-make' failed
make[3]: *** [__sub-make] Error 2
make[3]: Leaving directory '/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/debian/build/build_amd64_none_amd64'
debian/rules.real:190: recipe for target 'debian/stamps/build_amd64_none_amd64' failed

@lguohan
Copy link
Contributor

lguohan commented Feb 11, 2020

not sure retry will help. check build error below.

/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c: In function 'cafe_nand_probe':
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:656:23: error: 'NAND_OWN_BUFFERS' undeclared (first use in this function)
  cafe->nand.options = NAND_OWN_BUFFERS;
                       ^~~~~~~~~~~~~~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:656:23: note: each undeclared identifier is reported only once for each function it appears in
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:727:19: error: invalid application of 'sizeof' to incomplete type 'struct nand_buffers'
     2112 + sizeof(struct nand_buffers) +
                   ^~~~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:734:12: error: 'struct nand_chip' has no member named 'buffers'
  cafe->nand.buffers = nbuf = (void *)cafe->dmabuf + 2112;
            ^
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:748:6: error: dereferencing pointer to incomplete type 'struct nand_buffers'
  nbuf->ecccalc = NULL;
      ^~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:750:2: error: invalid use of undefined type 'struct nand_buffers'
  nbuf->databuf = (uint8_t *)(nbuf + 1);
  ^~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:797:18: error: invalid application of 'sizeof' to incomplete type 'struct nand_buffers'
    2112 + sizeof(struct nand_buffers) +
                  ^~~~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c: In function 'cafe_nand_remove':
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/cafe_nand.c:825:18: error: invalid application of 'sizeof' to incomplete type 'struct nand_buffers'
    2112 + sizeof(struct nand_buffers) +
                  ^~~~~~
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/scripts/Makefile.build:315: recipe for target 'drivers/mtd/nand/raw/cafe_nand.o' failed
make[9]: *** [drivers/mtd/nand/raw/cafe_nand.o] Error 1
make[9]: *** Waiting for unfinished jobs....
  CC [M]  drivers/media/pci/mantis/mantis_vp2040.o
/var/johnar/workspace/common/linux-kernel-build-pr/linux-4.9.189/drivers/mtd/nand/raw/nandsim.c:43:28: fatal error: linux/sched/mm.h: No such file or directory
 #include <linux/sched/mm.h>
                            ^
compilation terminated.

Arm64 PCI mmap resource from user space using sysfs
Arm64 /proc/dma file access

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@lguohan
Copy link
Contributor

lguohan commented Feb 12, 2020

please identify the upstream commit id and the start linux version that introduce this patch.

check below for example

https://github.com/Azure/sonic-linux-kernel/blob/master/patch/linux-4.13-thermal-intel_pch_thermal-Fix-enable-check-on.patch

@lguohan
Copy link
Contributor

lguohan commented Feb 14, 2020

i can see quite a few patches for armada 7020 is in 4.19. can you check when armada 7020 is fully supported in linux kernel. since we are moving to 4.19 in this release. maybe we can support this 7020 in the coming 4.19 release instead of back port this to 4.9 release. there are quite a few changes related to general function which can impact other platforms. I have concerns to back port this patch to 201911 release.

@antony-rheneus
Copy link
Contributor Author

i can see quite a few patches for armada 7020 is in 4.19. can you check when armada 7020 is fully supported in linux kernel. since we are moving to 4.19 in this release. maybe we can support this 7020 in the coming 4.19 release instead of back port this to 4.9 release. there are quite a few changes related to general function which can impact other platforms. I have concerns to back port this patch to 201911 release.

From 4.14, Armada 7020 is fully supported and upstreamed.
I agree with you, as it is platform dependent and not a generic patch, to would affect or break when we do version migration.

@lguohan
Copy link
Contributor

lguohan commented Mar 20, 2020

great, then I will skip these patches for 4.9 kernel. We plan to get to debian buster 4.19 for sonic 202006 release

@antony-rheneus
Copy link
Contributor Author

great, then I will skip these patches for 4.9 kernel. We plan to get to debian buster 4.19 for sonic 202006 release

Thanks, I will keep this PR open till we move to latest kernel, as we maintain list open PRs to patch while building SONIC image for Marvell.

@jarias-lfx
Copy link

/easycla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants