-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch]: Allow user to set metric on default route learned via Router Advertisement. #180
base: master
Are you sure you want to change the base?
Conversation
385ad2d
to
ca7ea87
Compare
@praveen-li , you can create it as a "draft" PR :) |
@prsunny, Yeah, For next time, I will remember abt draft PRs :) |
you can convert to draft pr. |
Okies, did it. Thx. |
1104a15
to
c102a6b
Compare
is this back port fix? |
We will raise it with the Linux kernel community, if they merge, we will backport till 4.9. Yeah this patch is applicable only till 4.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch.
- Please follow the Linux kernel coding style.
- Please develop against Linux master, and submit the patch upstream as early as possible – even as RFC (request for comments) – so the Linux network developers can review the idea as early as possible.
- Please extend the commit messages, and even give an explanation, why this feature is a good idea, and add performance numbers without and with this feature enabled.
e24b267
to
a3bcfed
Compare
Signed-off-by: Praveen Chaudhary<pchaudhary@linkedin.com>
a3bcfed
to
b714e69
Compare
4a5af9d
to
f43d588
Compare
can you add commit message in the patch? |
/easycla |
This PR is merged in Linux 5.12, we can keep it as patch till we reach Linux 5.12.
torvalds/linux@6b2e04b
Allow user to set metric on default route learned via Router Advertisement.
Note: RFC 4191 does not say anything for metric for IPv6 default route.
Fix:
For IPv4, default route is learned via DHCPv4 and user is allowed to change
metric using config in etc/network/interfaces. But for IPv6, default route can
be learned via RA, for which, currently a fixed metric value 1024 is used.
Ideally, user should be able to configure metric on default route for IPv6
similar to IPv4. This fix adds sysctl for the same.
Logs:
For IPv4:
Config in etc/network/interfaces
IPv4 Kernel Route Table:
FRR Table, if default route is learned via routing protocol too.
i.e. User can prefer Default Router learned via Routing Protocol,
Similar behavior is not possible for IPv6, without this fix.
After fix [for IPv6]:
IP monitor:
Kernel IPv6 routing table
FRR Routing Table, if default route is learned via routing protocol.