Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marvell-arm64 : Add DB-CN913X-Compexpress board support #337

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pavannaregundi
Copy link
Contributor

@pavannaregundi pavannaregundi commented Sep 29, 2023

This change adds device tree files and makes kconfig inclusions required for
Marvell CN913x ComExpress development board.

The DB-CN913X-ComExpress Card is a basic Type 7 module, aimed to serve
as a system management for the Switch family boards.

The CN9130 composed of:

  • AP807 consisting of Quad Core ARMv8 Cortex-A72 and few peripherals.
  • One CP115 block that contains all the high-speed interfaces
    (PCIe, Ethernet, etc.).

CN9131 is comprised of a single CN9130 with additional CP115 block.

@pavannaregundi pavannaregundi requested a review from a team as a code owner September 29, 2023 12:03
@@ -0,0 +1,560 @@
From: Pavan Naregundi <pnaregundi@marvell.com>
Date: Thu, 14 Sep 2023 04:35:53 +0000
dts: marvell: Add DB-CN913X-Compexpress board
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate the patch with git format-patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patches are generated using git format-patch with commit id removed.


The CN9130 composed of:
- AP807 consisting of Quad Core ARMv8 Cortex-A72 and few peripherals.
- One CP115 block that contain all the high-speed interfaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. done.

(PCIe, Ethernet, etc.).

CN9131 is comprised from a single CN9130 with additional CP115 block.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the URL, where you have sent this upstream for review/inclusion.

Copy link
Contributor Author

@pavannaregundi pavannaregundi Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we have cn913x-db.dts and cn913x-crb.dts upstreamed in Linux kernel. This board(cn913x-db-comexpress.dts) is a variant of cn913x-crb.dts. If upstream is still needed, we need to push them for upstream review.

Copy link
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of arm64: Add kconfig inclusions, please make it two commits with more descriptive and specific commit messages. For example:

  1. arm64: Select CONFIG_PHY_MVEBU_CP110_COMPHY
  2. arm64: Select CONFIG_SPI_ORION

@pavannaregundi
Copy link
Contributor Author

Instead of arm64: Add kconfig inclusions, please make it two commits with more descriptive and specific commit messages. For example:

  1. arm64: Select CONFIG_PHY_MVEBU_CP110_COMPHY
  2. arm64: Select CONFIG_SPI_ORION

As upstream effort may take some time for dts files. We would like this config to be pushed. Hence will raise a separate PR for these. Will separate the config commits as you suggested above.

This change adds device tree files for Marvell CN913x ComExpress
development board.

The DB-CN913X-ComExpress Card is a basic Type 7 module, aimed to serve
as a system management for the Switch family boards.

The CN9130 composed of:
- AP807 consisting of Quad Core ARMv8 Cortex-A72 and few peripherals.
- One CP115 block that contains all the high-speed interfaces
(PCIe, Ethernet, etc.).

CN9131 is comprised of a single CN9130 with additional CP115 block.

Change-Id: Ibe33d5ef27fd00b367ead6c737dd7e7a4e3f912f
Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
@pavannaregundi
Copy link
Contributor Author

Instead of arm64: Add kconfig inclusions, please make it two commits with more descriptive and specific commit messages. For example:

  1. arm64: Select CONFIG_PHY_MVEBU_CP110_COMPHY
  2. arm64: Select CONFIG_SPI_ORION

As upstream effort may take some time for dts files. We would like this config to be pushed. Hence will raise a separate PR for these. Will separate the config commits as you suggested above.

New PR for only kconfig changes - #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants