config_facts enhancements for multi-asic and support in SonicAsic #2435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Currently, the config_facts ansible module lacks the following:
Also, we need add wrapper method for config_facts to SonicAsic class for being able to use it for multi-asic multi-dut testbeds.
How did you do it?
In config_facts ansible module:
To support no PORT metadata, in create_maps method define the port maps as empty dictionary. If 'PORT' is in the config, then only populate these port maps. So, if there is no 'PORT" in the config, return empty dictionaries.
To support 'persistent' config_facts across namespace, changed PERSISTENT_CONFIG_PATH to be '/etc/sonic/config_db{}.json". If namespace is passed, we will format PERSISTENT_CONFIG_PATH with asic_id based on the namespace, else we will format this with an empty string.
SonicAsic:
How did you verify/test it?
Tested it against pizza box, multi-asic pizza box, and chassis with multi-asic line cards and supervisor card.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation