[platform/sfp] Add test cases for SFP error status #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add test cases for sfputil show error-status - Add platform test for SFP.get_error_description() Signed-off-by: Stephen Sun <stephens@nvidia.com>
- Remove unused variable - Simplify the fixture of the command Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
@jleveque can you review this PR when you have time? thanks. |
jleveque
suggested changes
Jun 29, 2021
Signed-off-by: Stephen Sun <stephens@nvidia.com>
jleveque
approved these changes
Jun 29, 2021
- Skip the test if error status isn't supported - Skip the test on versions 202012, 201911, 201811 - Add comments Signed-off-by: Stephen Sun <stephens@nvidia.com>
liat-grozovik
approved these changes
Jun 30, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Add test cases for SFP error status - Add test cases for sfputil show error-status - Add platform test for SFP.get_error_description() Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add test cases for SFP error status
Signed-off-by: Stephen Sun stephens@nvidia.com
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add test cases for SFP error status
How did you do it?
How did you verify/test it?
Run regression test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation