Generic Config Updater Syslog server test #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd verify that in tests
|
This pull request introduces 1 alert when merging 054dd9f into f82932a - view on LGTM.com new alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
|
sonic-syslog.yang is needed to complete the test. |
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 24, 2021
qiluo-msft
reviewed
Nov 30, 2021
wen587
changed the title
qiluo-msft
approved these changes
Dec 1, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…c config updater (sonic-net#4725) Summary: Testcase of Syslog server for generic updater apply-patch What is the motivation for this PR? End to End test support for Generic Config Updater apply-patch This PR is to verify the usage of 'config apply-patch' works on Syslog server How did you do it? First, we set up a clean Syslog env. Then make some config apply change. And check if the Syslog server is changed as expected. Updated start-limit-hit function in gu_utils.py How did you verify/test it? Run test of sonic-mgmt/tests/generic_config_updater/test_syslog.py on KVM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Testcase of syslog server for generic updater apply-patch
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on syslog server
How did you do it?
First we setup clean syslog env. Then make some config apply change. And check if the syslog server is changed as expected.
Updated start-limit-hit function in
gu_utils.pyHow did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_syslog.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation