GCU portchannel interface test #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Dec 27, 2021
| # } | ||
|
|
||
| pytestmark = [ | ||
| pytest.mark.topology('t0'), |
There was a problem hiding this comment.
Can you find me a t1-lag topo? I can check if the test can be adopted.
There was a problem hiding this comment.
Maybe add t1-lag in another PR.
In this testcase, we are actually modifying the interface, like ip and attributes(mtu, min-link). Topo should not make any difference right?
qiluo-msft
reviewed
Dec 27, 2021
| output = apply_patch(duthost, json_data=json_patch, dest_file=tmpfile) | ||
| expect_op_success(duthost, output) | ||
|
|
||
| verify_attr_change(duthost, name, attr, value) |
There was a problem hiding this comment.
How about checking portchannel pid?
docker exec -it teamd test -f /var/run/teamd/PortChannel0001.pid
There was a problem hiding this comment.
Checking process such as command ps is better. There is risk that the process crashed but the pid file is still there.
There was a problem hiding this comment.
Changed to state dump verification
qiluo-msft
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Testcase of portchannel interface for generic updater apply-patch
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on portchannel interface
How did you do it?
First we setup clean portchannel interface env. Then make some config apply change. And check if the portchannel interfaces changed as expected.
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_portchannel_interface.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation