Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCU test for BGPListener(BGPMonitor) #4987

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Jan 20, 2022

Description of PR

Summary: Testcase of BGPListener(BGPMonitor) for generic updater apply-patch
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on BGPL

How did you do it?

Make some config apply change. And check if the BGPLconfig changed as expected.

How did you verify/test it?

Run test of sonic-mgmt/tests/generic_config_updater/test_bgpl.py on KVM

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wen587 wen587 requested review from qiluo-msft and ghooo January 21, 2022 06:31
"BGPMonitor with addr {} is not being setup.".format(addr)
)

def bgpmon_tc1_add_init(duthost, bgpmon_setup_info):
Copy link
Contributor

@qiluo-msft qiluo-msft Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bgpmon_tc1_add_init

Do we need extra testcases to admin up/down an existing peer? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add admin down test for existing bgpmon.

@wen587 wen587 marked this pull request as ready for review January 25, 2022 05:03
@wen587 wen587 requested a review from a team as a code owner January 25, 2022 05:03
@wen587 wen587 merged commit 16a7d03 into sonic-net:master Jan 26, 2022
lolyu pushed a commit to lolyu/sonic-mgmt that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants