GCU test for bgp speaker #5234
Merged
GCU test for bgp speaker #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
previously approved these changes
Feb 28, 2022
qiluo-msft
reviewed
Feb 28, 2022
| pytest.fail("Invalid ip version!") | ||
|
|
||
| bgp_speaker_config_cleanup(duthost) | ||
| bgp_speaker_tc1_add_config(duthost, lo_intf_ip, vlan_intf_ip_range, bgp_speaker) |
There was a problem hiding this comment.
I guess they are the same. Do you think testing them together is better?
ghooo
reviewed
Feb 28, 2022
| bgp_speaker_config_cleanup(duthost) | ||
| bgp_speaker_tc1_add_config(duthost, lo_intf_ip, vlan_intf_ip_range, bgp_speaker) | ||
| bgp_speaker_tc1_add_dummy_ip_range(duthost, bgp_speaker, dummy_ip_range) | ||
| bgp_speaker_tc1_rm_dummy_ip_range(duthost, bgp_speaker, dummy_ip_range) |
There was a problem hiding this comment.
Can we add a test for changing the src_address .. for example switching from loopback0 to loobpack1?
Also, we would like to test adding a new VLAN and also a new Loopback is that covered under VLAN/Loopback testing? (i think so, just double checking). #Closed
There was a problem hiding this comment.
Added src_address change to a dummy ip.
Also, we would like to test adding a new VLAN and also a new Loopback is that covered under VLAN/Loopback testing? (i think so, just double checking).
Yes. That is covered.
ghooo
approved these changes
Mar 1, 2022
qiluo-msft
approved these changes
Mar 2, 2022
ganglyu
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
[Done]Wait for yang model sonic-net/sonic-buildimage#10082
and create-only fix to merge.
Summary: Testcase of bgp speaker config for generic updater apply-patch
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
End to End test support for Generic Updater apply-patch
This PR is to verify the usage of 'config apply-patch' works on bgp speaker config
How did you do it?
Add bgp speaker config to dut and check if config change as expected
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_bgp_speaker.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation