[GCU] Add rollback validation test #5469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Apr 6, 2022
qiluo-msft
reviewed
Apr 6, 2022
| "'{}' failed with rc={}".format(cmds, output['rc']) | ||
| ) | ||
|
|
||
| bgp_listener_pattern = r".*BGPMonitor.*" |
There was a problem hiding this comment.
Could you add one sample line as code comment? Suggest to make regex more strict. #Closed
There was a problem hiding this comment.
Talking about strict regex, from you sample line, you may use BGPMonitor$
There was a problem hiding this comment.
Sample of stdout: neighbor 11.0.0.1 description BGPMonitor\n neighbor 10.0.0.57 remote-as 64600\n neighbor 10.0.0.57 peer-group PEER_V4\n
Ending character $ will not match.
I change to runningconfig verification. Because some counter such as MsgRcvd will not be the same after rollback.
qiluo-msft
reviewed
Apr 6, 2022
qiluo-msft
reviewed
Apr 6, 2022
qiluo-msft
reviewed
Apr 6, 2022
qiluo-msft
reviewed
Apr 6, 2022
qiluo-msft
reviewed
Apr 6, 2022
qiluo-msft
previously approved these changes
Apr 7, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wen587
force-pushed
the
rollback_validation
branch
from
faf801b to
c681b41
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Improve GCU test by adding rollback validation test
[still pending06/01] merge after sonic-net/sonic-utilities#2145
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Cover test gap for GCU rollback
How did you do it?
Record config before test start, then compare if config is the same after rollback.
How did you verify/test it?
Run test of sonic-mgmt/tests/generic_config_updater/test_bgp*.py on KVM
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation