Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMIS]Fix low-power to high power mode transition #268

Merged
merged 5 commits into from
May 4, 2022

Conversation

prgeor
Copy link
Collaborator

@prgeor prgeor commented Mar 10, 2022

Description

  1. Ensure the CMIS module transition fully under SW control while transitioning from LowPwr to HighPower
  2. Since now only python3 is supported, use python generator expression for few fields in CmisMmap
  3. Remove python2 tests from azure pipeline

Motivation and Context

In Arista switch, 400G ZR module did not transition from LowPwr -> HighPwr. This is because LowPwrAllowRequestHW =1 by default, meaning the module LowPwr state could still be controlled by LowPwrRequestHW signal

How Has This Been Tested?

  1. python3 -m pytest
  2. Verified 400G ZR module transition from LowPwr -> HighPwr
  3. Transceiver info is displayed correctly

@prgeor
Copy link
Collaborator Author

prgeor commented Mar 10, 2022

@aravindmani-1 can you review?

aravindmani-1
aravindmani-1 previously approved these changes Mar 10, 2022
@prgeor prgeor merged commit d62d3d6 into sonic-net:master May 4, 2022
@prgeor
Copy link
Collaborator Author

prgeor commented May 5, 2022

@rlhui could you please cherry pick this PR to 20211?

itamar-talmon pushed a commit to itamar-talmon/sonic-platform-common that referenced this pull request Jan 12, 2023
* [CMIS]Fix low-power to high power mode transition

* Remove python2 tests

* Improve code coverage

* Parametrize the test

* Improve code coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants