-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
400G-ZR : Time window based PM statistics collection #390
Open
jaganbal-a
wants to merge
7
commits into
sonic-net:master
Choose a base branch
from
jaganbal-a:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer to the HLD for problem description and design. HLD: sonic-net/SONiC#1258
|
jaganbal-a
changed the title
Signed-off-by: Jaganathan Anbalagan <jaganbal@cisco.com>
400G-ZR : Time window based PM statistics collection
Jul 21, 2023
PM statistics is collected through scheduler
Made changes to control vdm freeze and unfreeze pm_mgr.
60sec window will not be filled if the platform uses 120sec pm_interval, removed white space
removed the _TABLE from the TRANSCEIVER_PM_WINDOW_STATS table name.
Corrected the function header.
longhuan-cisco
approved these changes
Sep 7, 2023
@longhuan-cisco : Can you please provide when you you will resolve the conflict ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
window based PM statistics collection. Please refer to the HLD for more details sonic-net/SONiC#1258
Motivation and Context
As per the above HLD, PM stats history is not present/maintained for 400G-ZR modules as of today.
This PR has the changes to collect PM stats and store in time window of different granularity in state-DB as described in the HLD. The stored PM stats for each window of a port then can be retrieved by CLI defined in the HLD.
How Has This Been Tested?
The changes are tested with inphi and acacia 400G-ZR modules on Cisco LC88-36FH-M-O pid.