[CMIS] Skip re-init flow for SW-controlled ports in case of fastboot #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
approved these changes
Apr 25, 2024
vadymhlushko-mlnx
force-pushed
the
master-fastboot-skip-cmis-reinit
branch
2 times, most recently
from
9d01dfd to
a20f465
Compare
prgeor
reviewed
Apr 29, 2024
sonic-xcvrd/xcvrd/xcvrd.py
Outdated
| api.tx_disable_channel(media_lanes_mask, True) | ||
| self.update_port_transceiver_status_table_sw_cmis_state(lport, CMIS_STATE_READY) | ||
| continue | ||
| if is_fast_reboot: |
There was a problem hiding this comment.
@vadymhlushko-mlnx why host_tx_ready is false during fast-reboot?
vadymhlushko-mlnx
force-pushed
the
master-fastboot-skip-cmis-reinit
branch
2 times, most recently
from
bced7e7 to
1cc714e
Compare
vadymhlushko-mlnx
force-pushed
the
master-fastboot-skip-cmis-reinit
branch
from
b8e7e42 to
d9b01f3
Compare
Signed-off-by: vadymhlushko-mlnx <vadymh@nvidia.com>
vadymhlushko-mlnx
force-pushed
the
master-fastboot-skip-cmis-reinit
branch
from
d9b01f3 to
98c6d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip the re-init flow for the SW-controlled ports in case of fastboot.
Because during fastboot the switch didn't reset the modules, so there is no need to reinitialize them.
Motivation and Context
To improve the fastboot data-plane disruption time.
How Has This Been Tested?
Run the sonic-mgmt/tests/platform_tests/test_advanced_reboot.py::test_fast_reboot
Additional Information (Optional)