Fix the compilation error because github.com/go-redis/redis moved to v-8 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
got merge v8 branch which made this argument mandatory for the API's that are failing. To fix this passing context.TODO() based on refernece redis/commands_test.go
pavel-shirshov
approved these changes
May 21, 2020
|
v8 is a beta version: https://pkg.go.dev/github.com/go-redis/redis/v8?tab=doc |
|
/easycla |
|
very old pr. not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix the compilation error because github.com/go-redis/redis moved
to v8 branch which made the ctx argument mandatory for the API's
that are failing compilation error.
To fix this passing context.TODO() based on reference redis/commands_test.go
How I verify
verified Compilation is fine after this change.