Get port configuration from ConfigDB instead of AppDB #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
requested review from
mykolaf,
SuvarnaMeenakshi,
lguohan and
prsunny
prsunny
reviewed
Aug 28, 2020
| if if_name in self.if_name_map: | ||
| if_table = mibs.if_entry_table(if_name) | ||
| if_table = mibs.if_entry_table_config_db(if_name) |
There was a problem hiding this comment.
Why we cannot get everything from APP_DB? As you mentioned, "oper_status" is only in APP_DB. Also if there is no config_db entry for MTU, then there is a default 9100 MTU created only in APP_DB table.
|
/azpw run |
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 157 in repo Azure/sonic-snmpagent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Due to history issue, the configuration of port are moved from AppDB to ConfigDB, and the data in AppDB is just for backward-compatible. We need to migrate the snmpagent to access ConfigDB for port configuration such as admin_status/alias etc. However, the oper_status is still in AppDB.
Add test cases for InterfaceMIB.
- How I did it
- How to verify it
- Description for the changelog