[schema] Add next hop group table to schema #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @adamyeung - could you please add BRCM team to review this PR, thanks. |
prsunny
reviewed
Apr 12, 2021
prsunny
reviewed
Aug 11, 2021
common/schema.h
Outdated
| @@ -39,6 +39,7 @@ namespace swss { | |||
| #define APP_FDB_TABLE_NAME "FDB_TABLE" | |||
| #define APP_PFC_WD_TABLE_NAME "PFC_WD_TABLE" | |||
| #define APP_SWITCH_TABLE_NAME "SWITCH_TABLE" | |||
| #define APP_NEXT_HOP_GROUP_TABLE_NAME "NEXT_HOP_GROUP_TABLE" | |||
There was a problem hiding this comment.
I think it can be renamed as APP_NEXTHOP_GROUP_TABLE_NAME instead of NEXT_HOP.
prsunny
previously approved these changes
Aug 11, 2021
|
@prsunny any idea what's causing the failing checks and if they'll work with a retry? I'm pretty confident that my 1 line addition of a #define isn't causing the issues! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
previously approved these changes
Aug 13, 2021
|
Could you rebase your code to latest master? |
|
@qiluo-msft Done |
qiluo-msft
approved these changes
Aug 13, 2021
|
/azp run |
|
Commenter does not have sufficient privileges for PR 475 in repo Azure/sonic-swss-common |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.