-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code changes to support IPv6 Link local enhancements #1463
Code changes to support IPv6 Link local enhancements #1463
Conversation
retest vs please |
Hi, all I'm testing this patch, but I got this error:
I found this error is because "swss add same route twice or more". So how to deal with this? |
8c5b06a
to
0baba1c
Compare
@arlakshm Please retest it, as I don't have permission for Azurepipelines run. |
/azp run |
Commenter does not have sufficient privileges for PR 1463 in repo Azure/sonic-swss |
/Azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The failures are not related to the code changes, Please check it. |
Please re-run the build, as the failures are not related to the code changes. |
@arlakshm - could you please help with re-run. |
can you add vstest? |
@AkhileshSamineni , can you do a rebase and push? |
0fb6a09
to
7053e33
Compare
This pull request introduces 1 alert when merging a726b09 into 5847af3 - view on LGTM.com new alerts:
|
@lguohan Added VS test cases. |
@lguohan @prsunny Done rebase and pushed the changes. Now I see vrf_creation is failing in most of the test cases, which were not related to my changes. Could you please check. |
/azpw run |
/AzurePipelines run |
Commenter does not have sufficient privileges for PR 1463 in repo Azure/sonic-swss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config.
I think, BGP unnumbered use-case is expected to work without this field explicitly configured as ipv6 enabled by default globally on all interfaces i.e LLA should be present., right?
Wondering what's the expectation on the community image for BGP unnumbered functionality to work,
Should we need to disable ipv6 on all interfaces globally first and then enable per interface basis?
Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only".
This is no longer valid as we by default have ipv6 enabled on all interfaces.
Allow the ipv6 link-local address as neighbors.
Not sure why do we need LLA as neighbors.
@venkatmahalingam
|
hi @prsunny - could you please review and approve asap, this is needed in 202106 release |
@anshuv-mfst , waiting on one outstanding comment. @AkhileshSamineni , could you please check the unresolved comments and reply? |
@prsunny Added code changes to skip the ipv6 link-local netlink msg in neighsyncd when link-local-mode config is disabled. |
@venkatmahalingam , can you please sign off? |
As per HLD - sonic-net/SONiC#625 FRR Patches: 0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch Files modified : bgpd_network.c and bgpd/bgp_zebra.c Fix for : Link local scope was not set while binding socket with local address causing socket errors for bgp ipv6 link local neighbors. 0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch Files modified : staticd/static_zebra.c Fix for : VRF interface lookup was still done in the default-vrf which was causing the interface lookup to fail. Due to this static-route pointing to link-local was not getting installed. 0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch Files modified : zebra/zebra_fpm_netlink.c Fix for : Made changes to send ipv6 address as nexthop to fpmsyncd. Depends on: sonic-net/sonic-utilities#1159 sonic-net/sonic-swss#1463 Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com
As per HLD - sonic-net/SONiC#625 FRR Patches: 0009-Link-local-scope-was-not-set-while-binding-socket-for-bgp-ipv6-link-local-neighbors.patch Files modified : bgpd_network.c and bgpd/bgp_zebra.c Fix for : Link local scope was not set while binding socket with local address causing socket errors for bgp ipv6 link local neighbors. 0010-VRF-interface-lookup-was-still-done-in-the-default-vrf.patch Files modified : staticd/static_zebra.c Fix for : VRF interface lookup was still done in the default-vrf which was causing the interface lookup to fail. Due to this static-route pointing to link-local was not getting installed. 0011-Changes-to-send-ipv6-link-local-address-as-nexthop-to-fpmsyncd.patch Files modified : zebra/zebra_fpm_netlink.c Fix for : Made changes to send ipv6 address as nexthop to fpmsyncd. Depends on: sonic-net/sonic-utilities#1159 sonic-net/sonic-swss#1463 Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com
* Code changes to support IPv6 Link local enchancements - Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config. - Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only". - Allow the ipv6 link-local address as neighbors. - Allow adding the IPv6 routes with link-local nexthops. - Skip Ipv4LL neighbor add in Orchagent for RFC5549. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
* Code changes to support IPv6 Link local enchancements - Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config. - Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only". - Allow the ipv6 link-local address as neighbors. - Allow adding the IPv6 routes with link-local nexthops. - Skip Ipv4LL neighbor add in Orchagent for RFC5549. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
* Code changes to support IPv6 Link local enchancements - Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config. - Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only". - Allow the ipv6 link-local address as neighbors. - Allow adding the IPv6 routes with link-local nexthops. - Skip Ipv4LL neighbor add in Orchagent for RFC5549. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
* Code changes to support IPv6 Link local enchancements - Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config. - Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only". - Allow the ipv6 link-local address as neighbors. - Allow adding the IPv6 routes with link-local nexthops. - Skip Ipv4LL neighbor add in Orchagent for RFC5549. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
* Code changes to support IPv6 Link local enchancements - Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config. - Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only". - Allow the ipv6 link-local address as neighbors. - Allow adding the IPv6 routes with link-local nexthops. - Skip Ipv4LL neighbor add in Orchagent for RFC5549. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
The key used is as read from APPL-DB, hence use it as such to get the value, to help get the interfce name, so it can be used for filtering out.
…thub.com> Date: Thu Aug 5 23:49:44 2021 +0530 Code changes to support IPv6 Link local enhancements (sonic-net#1463)
* Code changes to support IPv6 Link local enchancements - Changes to handle the "ipv6_use_link_local_only" option on a interface which is added/deleted based on Global Config or Interface config. - Adds/Deletes the RIF for an interface in the absence of IPv6 global address on a interface based on "ipv6_use_link_local_only". - Allow the ipv6 link-local address as neighbors. - Allow adding the IPv6 routes with link-local nexthops. - Skip Ipv4LL neighbor add in Orchagent for RFC5549. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
orchagent/vrforch.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AkhileshSamineni Could you please share the reason why this part of code was removed? There is a long opened PR #1926 added this code back. Without this changes the BGP unnumbered cannot work properly with VRF.
Code changes :
As per HLD - sonic-net/SONiC#625
Depends on :
sonic-net/sonic-utilities#1159
sonic-net/sonic-buildimage#5584
Signed-off-by: Akhilesh Samineni akhilesh.samineni@broadcom.com