fix config qos clear and key only update #1562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lguohan - pls help with review - thx |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
+ update 'show ip interface' command in tech support collection + fix unbound variable issue in case command times out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix config qos clear command.
Why I did it
Queue table update without scheduler profile.
How I verified it
swssloglevel -l DEBUG -c orchagent
show log handleQueueTable
Dec 21 17:56:57.275101 sonic DEBUG swss#orchagent: :> handleQueueTable: enter
Dec 21 17:56:57.275305 sonic DEBUG swss#orchagent: :- handleQueueTable: processing port:Ethernet8
Dec 21 17:56:57.275305 sonic DEBUG swss#orchagent: :- handleQueueTable: processing range:1-1
Dec 21 17:56:57.275305 sonic DEBUG swss#orchagent: :- handleQueueTable: processing queue:1
Dec 21 17:56:57.424246 sonic DEBUG swss#orchagent: :- handleQueueTable: Applied scheduler to port:Ethernet8 queue:1
Dec 21 17:56:57.424246 sonic DEBUG swss#orchagent: :- handleQueueTable: finished
Dec 21 17:56:57.424246 sonic DEBUG swss#orchagent: :< handleQueueTable: exit
Dec 21 17:56:57.424246 sonic DEBUG swss#orchagent: :> handleQueueTable: enter
Dec 21 17:56:57.424449 sonic DEBUG swss#orchagent: :- handleQueueTable: processing port:Ethernet8
Dec 21 17:56:57.424488 sonic DEBUG swss#orchagent: :- handleQueueTable: processing range:2-2
Dec 21 17:56:57.424609 sonic DEBUG swss#orchagent: :- handleQueueTable: processing queue:2
Dec 21 17:56:57.447642 sonic DEBUG swss#orchagent: :- handleQueueTable: Applied scheduler to port:Ethernet8 queue:2
Dec 21 17:56:57.447773 sonic DEBUG swss#orchagent: :- handleQueueTable: finished
Dec 21 17:56:57.447803 sonic DEBUG swss#orchagent: :< handleQueueTable: exit
Dec 21 17:57:09.835991 sonic DEBUG swss#orchagent: :> handleQueueTable: enter
Dec 21 17:57:09.836647 sonic DEBUG swss#orchagent: :- handleQueueTable: processing port:Ethernet8
Dec 21 17:57:09.837054 sonic DEBUG swss#orchagent: :- handleQueueTable: processing range:1-1
Dec 21 17:57:09.837188 sonic DEBUG swss#orchagent: :- handleQueueTable: processing queue:1
Dec 21 17:57:09.862697 sonic DEBUG swss#orchagent: :- handleQueueTable: Removed scheduler to port:Ethernet8 queue:1
Dec 21 17:57:09.862697 sonic DEBUG swss#orchagent: :- handleQueueTable: finished
Dec 21 17:57:09.862697 sonic DEBUG swss#orchagent: :< handleQueueTable: exit
Dec 21 17:57:09.862697 sonic DEBUG swss#orchagent: :> handleQueueTable: enter
Dec 21 17:57:09.862775 sonic DEBUG swss#orchagent: :- handleQueueTable: processing port:Ethernet8
Dec 21 17:57:09.862964 sonic DEBUG swss#orchagent: :- handleQueueTable: processing range:2-2
Dec 21 17:57:09.862964 sonic DEBUG swss#orchagent: :- handleQueueTable: processing queue:2
Dec 21 17:57:09.867682 sonic DEBUG swss#orchagent: :- handleQueueTable: Removed scheduler to port:Ethernet8 queue:2
Dec 21 17:57:09.867682 sonic DEBUG swss#orchagent: :- handleQueueTable: finished
Dec 21 17:57:09.867682 sonic DEBUG swss#orchagent: :< handleQueueTable: exit
Details if related
config load qos.json
config qos clear
qos.json
{
"QUEUE": {
"Ethernet8|1": {
"scheduler": "[SCHEDULER|port_qos_shaper@1]"
},
"Ethernet8|2": {
"scheduler": "[SCHEDULER|port_qos_shaper@2]"
}
},
"SCHEDULER": {
"port_qos_shaper@1": {
"pir": "10000",
"meter_type": "bytes"
},
"port_qos_shaper@2": {
"pir": "2500",
"meter_type": "bytes"
}
}
}