Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pfcwd] Remove APPL_DB queue in-storm status at pfcwd config removal and big red switch enable #1691

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

[pfcwd] Remove APPL_DB queue in-storm status at pfcwd config removal and big red switch enable #1691

wants to merge 53 commits into from

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Apr 5, 2021

What I did
APPL_DB tracks in-storm queues for potential warm-reboot. In the following two scenarios, in-storm queues should be removed from APPL_DB.

  1. At pfcwd config removal from a port. When pfcwd config is removed from a port, pfcwd state machine stops running on {port, queue}. In-storm queues of the port should be removed from APPL_DB.

  2. At big red switch enable. Since later at big red switch mode disable, pfcwd state machine on {port, queue} resumes running from operational status, in-storm queues of the port should be removed from APPL_DB when big red switch mode is enabled. Meanwhile, since big red switch mode is tracked in CONFIG_DB, if the system warm-reboots with big red switch mode enabled, no run-time states need to be tracked elsewhere.

This PR amends and verifies the two scenarios described above.

Why I did it

How I verified it

vs tests:

Scenario 1: Piggy-back over test_pfc_en_bits_user_wd_cfg_sep developed in #1612

Without the change, extension to test pfc_en_bits_user_wd_cfg_sep fails

========================================================================= FAILURES =========================================================================
________________________________________________________ TestPfcWd.test_pfc_en_bits_user_wd_cfg_sep ________________________________________________________

self = <test_pfcwd.TestPfcWd object at 0x7f626c1c4400>, dvs = <conftest.DockerVirtualSwitch object at 0x7f626c1c4cf8>
testlog = <function testlog at 0x7f626c30f0d0>

    def test_pfc_en_bits_user_wd_cfg_sep(self, dvs, testlog):
        self.connect_dbs(dvs)
    
        # Enable pfc wd flex counter polling
        self.enable_flex_counter(CFG_FLEX_COUNTER_TABLE_PFCWD_KEY)
        # Verify pfc wd flex counter status published to FLEX_COUNTER_DB FLEX_COUNTER_GROUP_TABLE by flex counter orch
        fv_dict = {
            FLEX_COUNTER_STATUS: ENABLE,
        }
        self.check_db_fvs(self.flex_cntr_db, FC_FLEX_COUNTER_GROUP_TABLE_NAME, FC_FLEX_COUNTER_GROUP_TABLE_PFC_WD_KEY, fv_dict)
    
        # Enable pfc on tc 3
        pfc_tcs = [QUEUE_3]
        self.set_port_pfc(PORT_UNDER_TEST, pfc_tcs)
    
        # Verify pfc enable bits in ASIC_DB
        port_oid = dvs.asicdb.portnamemap[PORT_UNDER_TEST]
        fv_dict = {
            "SAI_PORT_ATTR_PRIORITY_FLOW_CONTROL": "8",
        }
        self.check_db_fvs(self.asic_db, ASIC_PORT_TABLE_NAME, port_oid, fv_dict)
    
        # Start pfc wd (config) on port
        self.start_port_pfcwd(PORT_UNDER_TEST)
        # Verify port level counter to poll published to FLEX_COUNTER_DB FLEX_COUNTER_TABLE by pfc wd orch
        self.check_db_key_existence(self.flex_cntr_db, FC_FLEX_COUNTER_TABLE_NAME,
                                    "{}:{}".format(FC_FLEX_COUNTER_TABLE_PFC_WD_KEY_PREFIX, port_oid))
        # Verify queue level counter to poll published to FLEX_COUNTER_DB FLEX_COUNTER_TABLE by pfc wd orch
        q3_oid = self.get_queue_oid(dvs, PORT_UNDER_TEST, QUEUE_3)
        self.check_db_key_existence(self.flex_cntr_db, FC_FLEX_COUNTER_TABLE_NAME,
                                    "{}:{}".format(FC_FLEX_COUNTER_TABLE_PFC_WD_KEY_PREFIX, q3_oid))
    
        # Verify pfc enable bits stay unchanged in ASIC_DB
        time.sleep(2)
        fv_dict = {
            "SAI_PORT_ATTR_PRIORITY_FLOW_CONTROL": "8",
        }
        self.check_db_fvs(self.asic_db, ASIC_PORT_TABLE_NAME, port_oid, fv_dict)
    
        # Start pfc storm on queue 3
        self.start_queue_pfc_storm(q3_oid)
        # Verify queue in storm from COUNTERS_DB
        fv_dict = {
            PFC_WD_STATUS: STORMED,
        }
        self.check_db_fvs(self.cntrs_db, CNTR_COUNTERS_TABLE_NAME, q3_oid, fv_dict)
        # Verify queue in storm from APPL_DB
        fv_dict = {
            QUEUE_3: STORM,
        }
        self.check_db_fvs(self.appl_db, APPL_PFC_WD_INSTORM_TABLE_NAME, PORT_UNDER_TEST, fv_dict)
    
        # Verify pfc enable bits change in ASIC_DB
        fv_dict = {
            "SAI_PORT_ATTR_PRIORITY_FLOW_CONTROL": "0",
        }
        self.check_db_fvs(self.asic_db, ASIC_PORT_TABLE_NAME, port_oid, fv_dict)
    
        # Re-set pfc enable on tc 3
        pfc_tcs = [QUEUE_3]
        self.set_port_pfc(PORT_UNDER_TEST, pfc_tcs)
    
        # Verify pfc enable bits stay unchanged in ASIC_DB
        time.sleep(2)
        fv_dict = {
            "SAI_PORT_ATTR_PRIORITY_FLOW_CONTROL": "0",
        }
        self.check_db_fvs(self.asic_db, ASIC_PORT_TABLE_NAME, port_oid, fv_dict)
    
        # Change pfc enable bits: disable pfc on tc 3, and enable pfc on tc 4
        pfc_tcs = [QUEUE_4]
        self.set_port_pfc(PORT_UNDER_TEST, pfc_tcs)
    
        # Verify pfc enable bits change in ASIC_DB
        fv_dict = {
            "SAI_PORT_ATTR_PRIORITY_FLOW_CONTROL": "16",
        }
        self.check_db_fvs(self.asic_db, ASIC_PORT_TABLE_NAME, port_oid, fv_dict)
    
        # Stop pfc wd on port (i.e., remove pfc wd config from port)
        self.stop_port_pfcwd(PORT_UNDER_TEST)
        # Verify port level counter removed from FLEX_COUNTER_DB
        self.check_db_key_removal(self.flex_cntr_db, FC_FLEX_COUNTER_TABLE_NAME,
                                  "{}:{}".format(FC_FLEX_COUNTER_TABLE_PFC_WD_KEY_PREFIX, port_oid))
        # Verify queue level counter removed from FLEX_COUNTER_DB
        self.check_db_key_removal(self.flex_cntr_db, FC_FLEX_COUNTER_TABLE_NAME,
                                  "{}:{}".format(FC_FLEX_COUNTER_TABLE_PFC_WD_KEY_PREFIX, q3_oid))
        q4_oid = self.get_queue_oid(dvs, PORT_UNDER_TEST, QUEUE_4)
        self.check_db_key_removal(self.flex_cntr_db, FC_FLEX_COUNTER_TABLE_NAME,
                                  "{}:{}".format(FC_FLEX_COUNTER_TABLE_PFC_WD_KEY_PREFIX, q4_oid))
        # Verify pfc wd fields removed from COUNTERS_DB
        fields = [PFC_WD_STATUS]
        self.check_db_fields_removal(self.cntrs_db, CNTR_COUNTERS_TABLE_NAME, q3_oid, fields)
        self.check_db_fields_removal(self.cntrs_db, CNTR_COUNTERS_TABLE_NAME, q4_oid, fields)
        # Verify queue in storm status removed from APPL_DB
>       self.check_db_key_removal(self.appl_db, APPL_PFC_WD_INSTORM_TABLE_NAME, PORT_UNDER_TEST)

test_pfcwd.py:300: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
test_pfcwd.py:183: in check_db_key_removal
    db.wait_for_deleted_keys(table_name, [key])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <dvslib.dvs_database.DVSDatabase object at 0x7f626c1bca90>, table_name = 'PFC_WD_TABLE_INSTORM', deleted_keys = ['Ethernet64']
polling_config = PollingConfig(polling_interval=0.01, timeout=5.0, strict=True), failure_message = None

    def wait_for_deleted_keys(
        self,
        table_name: str,
        deleted_keys: List[str],
        polling_config: PollingConfig = PollingConfig(),
        failure_message: str = None,
    ) -> List[str]:
        """Wait for the specfied keys to no longer exist in the table.
    
        Args:
            table_name: The name of the table from which to fetch the keys.
            deleted_keys: The keys we expect to be removed from the table.
            polling_config: The parameters to use to poll the db.
            failure_message: The message to print if the call times out. This will only take effect
                if the PollingConfig is set to strict.
    
        Returns:
            The keys stored in the table. If no keys are found, then an empty List is returned.
        """
    
        def access_function():
            keys = self.get_keys(table_name)
            return (all(key not in keys for key in deleted_keys), keys)
    
        status, result = wait_for_result(
            access_function, self._disable_strict_polling(polling_config)
        )
    
        if not status:
            expected = [key for key in result if key not in deleted_keys]
            message = failure_message or (
                f"Unexpected keys found: expected={expected}, received={result}, "
                f'table="{table_name}"'
            )
>           assert not polling_config.strict, message
E           AssertionError: Unexpected keys found: expected=[], received=('Ethernet64',), table="PFC_WD_TABLE_INSTORM"

dvslib/dvs_database.py:437: AssertionError
================================================================= short test summary info ==================================================================
FAILED test_pfcwd.py::TestPfcWd::test_pfc_en_bits_user_wd_cfg_sep - AssertionError: Unexpected keys found: expected=[], received=('Ethernet64',), table="...
=============================================================== 1 failed in 69.23s (0:01:09) ===============================================================
Scenario 2: test_appl_db_storm_status_removal_brs
  1. Set PFC enable on {port, TC 3}
  2. Set PFC WD config on port to start PFC WD state machine on {port, TC 3}
  3. Mimic PFC storm on {port queue 3} using DEBUG_STORM
  4. Enable big red switch mode
  5. Dismiss PFC storm on {port, queue 3}
  6. Disable big red switch mode. PFC WD state machine resumes running on {port, queue 3}, and {port, queue 3} starts from and remains in operational status.

Without the change, {port, queue 3} in-storm status entry remains in APPL_DB after step 6.

========================================================================= FAILURES =========================================================================
_____________________________________________________ TestPfcWd.test_appl_db_storm_status_removal_brs ______________________________________________________

self = <test_pfcwd.TestPfcWd object at 0x7f8810369908>, dvs = <conftest.DockerVirtualSwitch object at 0x7f88103a73c8>
testlog = <function testlog at 0x7f88103990d0>

    def test_appl_db_storm_status_removal_brs(self, dvs, testlog):
        self.connect_dbs(dvs)
    
        # Enable pfc wd flex counter polling
        self.enable_flex_counter(CFG_FLEX_COUNTER_TABLE_PFCWD_KEY)
        # Verify pfc wd flex counter status published to FLEX_COUNTER_DB FLEX_COUNTER_GROUP_TABLE by flex counter orch
        fv_dict = {
            FLEX_COUNTER_STATUS: ENABLE,
        }
        self.check_db_fvs(self.flex_cntr_db, FC_FLEX_COUNTER_GROUP_TABLE_NAME, FC_FLEX_COUNTER_GROUP_TABLE_PFC_WD_KEY, fv_dict)
    
        # Enable pfc on tc 3
        pfc_tcs = [QUEUE_3]
        self.set_port_pfc(PORT_UNDER_TEST, pfc_tcs)
        # Verify pfc enable bits in ASIC_DB
        port_oid = dvs.asicdb.portnamemap[PORT_UNDER_TEST]
        fv_dict = {
            "SAI_PORT_ATTR_PRIORITY_FLOW_CONTROL": "8",
        }
        self.check_db_fvs(self.asic_db, ASIC_PORT_TABLE_NAME, port_oid, fv_dict)
    
        # Start pfc wd (config) on port
        self.start_port_pfcwd(PORT_UNDER_TEST)
        # Verify port level counter to poll published to FLEX_COUNTER_DB FLEX_COUNTER_TABLE by pfc wd orch
        self.check_db_key_existence(self.flex_cntr_db, FC_FLEX_COUNTER_TABLE_NAME,
                                    "{}:{}".format(FC_FLEX_COUNTER_TABLE_PFC_WD_KEY_PREFIX, port_oid))
        # Verify queue level counter to poll published to FLEX_COUNTER_DB FLEX_COUNTER_TABLE by pfc wd orch
        q3_oid = self.get_queue_oid(dvs, PORT_UNDER_TEST, QUEUE_3)
        self.check_db_key_existence(self.flex_cntr_db, FC_FLEX_COUNTER_TABLE_NAME,
                                    "{}:{}".format(FC_FLEX_COUNTER_TABLE_PFC_WD_KEY_PREFIX, q3_oid))
    
        # Start pfc storm on queue 3
        self.start_queue_pfc_storm(q3_oid)
        # Verify queue in storm from COUNTERS_DB
        fv_dict = {
            PFC_WD_STATUS: STORMED,
            PFC_WD_QUEUE_STATS_DEADLOCK_DETECTED: "1",
            PFC_WD_QUEUE_STATS_DEADLOCK_RESTORED: "0",
        }
        self.check_db_fvs(self.cntrs_db, CNTR_COUNTERS_TABLE_NAME, q3_oid, fv_dict)
        # Verify queue in storm from APPL_DB
        fv_dict = {
            QUEUE_3: STORM,
        }
        self.check_db_fvs(self.appl_db, APPL_PFC_WD_INSTORM_TABLE_NAME, PORT_UNDER_TEST, fv_dict)
    
        # Enable big red switch
        self.enable_big_red_switch()
        # Verify queue 3 in brs from COUNTERS_DB
        fv_dict = {
            BIG_RED_SWITCH_MODE: ENABLE,
            PFC_WD_STATUS: STORMED,
            PFC_WD_QUEUE_STATS_DEADLOCK_DETECTED: "2",
            PFC_WD_QUEUE_STATS_DEADLOCK_RESTORED: "1",
        }
        self.check_db_fvs(self.cntrs_db, CNTR_COUNTERS_TABLE_NAME, q3_oid, fv_dict)
    
        # Stop pfc storm on queue 3
        self.stop_queue_pfc_storm(q3_oid)
        # Verify DEBUG_STORM field removed from COUNTERS_DB
        fields = [DEBUG_STORM]
        self.check_db_fields_removal(self.cntrs_db, CNTR_COUNTERS_TABLE_NAME, q3_oid, fields)
    
        # Disable big red switch
        self.disable_big_red_switch()
        # Verify brs field removed from COUNTERS_DB
        fields = [BIG_RED_SWITCH_MODE]
        self.check_db_fields_removal(self.cntrs_db, CNTR_COUNTERS_TABLE_NAME, q3_oid, fields)
        # Verify queue operational from COUNTERS_DB
        fv_dict = {
            PFC_WD_STATUS: OPERATIONAL,
            PFC_WD_QUEUE_STATS_DEADLOCK_DETECTED: "2",
            PFC_WD_QUEUE_STATS_DEADLOCK_RESTORED: "2",
        }
        self.check_db_fvs(self.cntrs_db, CNTR_COUNTERS_TABLE_NAME, q3_oid, fv_dict)
    
        # Verify queue in-storm status removed from APPL_DB
>       self.check_db_key_removal(self.appl_db, APPL_PFC_WD_INSTORM_TABLE_NAME, PORT_UNDER_TEST)

test_pfcwd.py:509: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
test_pfcwd.py:185: in check_db_key_removal
    db.wait_for_deleted_keys(table_name, [key])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <dvslib.dvs_database.DVSDatabase object at 0x7f88102dd5c0>, table_name = 'PFC_WD_TABLE_INSTORM', deleted_keys = ['Ethernet64']
polling_config = PollingConfig(polling_interval=0.01, timeout=5.0, strict=True), failure_message = None

    def wait_for_deleted_keys(
        self,
        table_name: str,
        deleted_keys: List[str],
        polling_config: PollingConfig = PollingConfig(),
        failure_message: str = None,
    ) -> List[str]:
        """Wait for the specfied keys to no longer exist in the table.
    
        Args:
            table_name: The name of the table from which to fetch the keys.
            deleted_keys: The keys we expect to be removed from the table.
            polling_config: The parameters to use to poll the db.
            failure_message: The message to print if the call times out. This will only take effect
                if the PollingConfig is set to strict.
    
        Returns:
            The keys stored in the table. If no keys are found, then an empty List is returned.
        """
    
        def access_function():
            keys = self.get_keys(table_name)
            return (all(key not in keys for key in deleted_keys), keys)
    
        status, result = wait_for_result(
            access_function, self._disable_strict_polling(polling_config)
        )
    
        if not status:
            expected = [key for key in result if key not in deleted_keys]
            message = failure_message or (
                f"Unexpected keys found: expected={expected}, received={result}, "
                f'table="{table_name}"'
            )
>           assert not polling_config.strict, message
E           AssertionError: Unexpected keys found: expected=[], received=('Ethernet64',), table="PFC_WD_TABLE_INSTORM"

dvslib/dvs_database.py:437: AssertionError
================================================================= short test summary info ==================================================================
FAILED test_pfcwd.py::TestPfcWd::test_appl_db_storm_status_removal_brs - AssertionError: Unexpected keys found: expected=[], received=('Ethernet64',), ta...
=============================================================== 1 failed in 65.30s (0:01:05) ===============================================================

Details if related
Contains and therefore after #1612

wendani and others added 30 commits January 24, 2021 02:33
@wendani
Disable last tc
76add4b 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Adjust log level
099582e 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Introduce pfc bit mask status to track the pfc bit mask status in asic
41a9d4e 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Introduce private member function bool setPortPfcStatus(const Port &p…
fb4fef4 
…, uint8_t pfc_bitmask_status) to PortsOrch

Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
getPortPfc to get pfc status and cfg bit masks
c2ba1e0 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Overload setPortPfcStatus
5b1e38c 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Fix compile error
908166e 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Fix typo
b6e06d0 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Fix typo
d7fb1bf 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Set pfc bit in lossy handler destruction only if the corresponding bit
ddd480f 
in config is set

Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Update comment
53b2043 
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
@wendani
Update code format and comment
6c96bb6 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Merge remote-tracking branch 'origin/master' into pfc_bitmask
90cd76f
@wendani
Merge remote-tracking branch 'origin/master' into pfc_bitmask
60ade5d
@wendani
Merge remote-tracking branch 'origin/master' into pfc_bitmask
eb9f10a
@wendani
Merge remote-tracking branch 'public/master' into pfc_bitmask
eb46d98 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Fix typo
d08fe01 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Merge remote-tracking branch 'public/master' into pfc_bitmask
a2c2527
@wendani
Merge remote-tracking branch 'public/master' into pfc_bitmask
6979e38
@wendani
Merge remote-tracking branch 'public/master' into pfc_bitmask
f609c95
@wendani
Address comment: Revert log level
cbcdc3d 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Address comment: rename private function as setPortPfcStatus_
3668328 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Address comment: rename m_pfc_bitmask_cfg to m_pfc_bitmask_usercfg,
095c2de 
m_pfc_bitmask_status to m_pfc_bitmask_wdcfg

Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Address comment: getPortPfc use reference
31e366b 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Address comment: getPortPfc use reference in pfcactionhandler
19c5277 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Address comment: Address comment: getPortPfc use reference in pfcwdorch
625270c 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Address comment: getPortPfc use reference in setPortPfcAsym
f548b2d 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Update comment
12e6c1f 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Restore log level
df020b4 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Test case 1
47a8fad 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
wendani added 19 commits March 28, 2021 07:01
@wendani
Correct typo
26bb587 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Refactor
87f8dd0 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Use getBitMaskStr
50f60bf 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Test pfc enable bits clear
d8d8dff 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
If pfc enable bits stay unchanged, sleep 2 seconds before check; Reve…
6cf47b5 
…rt using getBitMaskStr(pfc_tcs)

Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
brd test case
f6d6e6d 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Add comment
e1bd125 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Check fc cntr db removal of both queues
ed11cac 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Rename variable
8de9ac4 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Rename variable
92a0e35 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Refactor
36d347b 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Rename variable
7fc6079 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Merge remote-tracking branch 'public/master' into pfc_bitmask
cbb2410 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Merge remote-tracking branch 'public/master' into pfc_bitmask
6673a9c
@wendani
Merge remote-tracking branch 'public/master' into pfc_bitmask
c491f08
@wendani
Remove {port, queue} in-storm status when pfc wd config on port is re…
63b6ba2 
…moved

Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Remove {port, queue} in-storm status when big red switch mode is enabled
7e59764 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Update code formats
d8b5e09 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Update code formats
116daf1 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2021

This pull request fixes 2 alerts when merging 116daf1 into 872b5cb - view on LGTM.com

fixed alerts:

  • 2 for Unused import

wendani added 4 commits April 5, 2021 09:51
@wendani
Use create_entry in place of raw hset
254d56c 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Update code formats
8248910 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani
Merge commit '8248910' into pfcwd_appl
e930ce4
@wendani
Clear queue deadlock counters
cedb134 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2021

This pull request fixes 2 alerts when merging cedb134 into 872b5cb - view on LGTM.com

fixed alerts:

  • 2 for Unused import

@wendani wendani mentioned this pull request Apr 6, 2021
Open
1 task
@lguohan lguohan added the pfcwd label Apr 24, 2021
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@neethajohn
[pfcwd] Fix the return code in invalid case (sonic-net#1691)
c5d00ae 
Signed-off-by: Neetha John <nejo@microsoft.com>

Fixes sonic-net#1690

What I did
Set the correct return code when pfcwd command is specified with invalid options

How to verify it
Modified the unit test to check for the correct return code and ran them and they passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neethajohn neethajohn Awaiting requested review from neethajohn

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pfcwd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendani @lguohan