-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pfcwd] Observe pfc enable bits change #1697
Open
wendani
wants to merge
111
commits into
sonic-net:master
Choose a base branch
from
wendani:pfcwd_observer_master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
…, uint8_t pfc_bitmask_status) to PortsOrch Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
in config is set Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
…moved Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
This pull request fixes 2 alerts when merging 4ce1bce into 66e1aab - view on LGTM.com fixed alerts:
|
@wendani , can you do a proper pr, too many commits in your pr. https://www.thinkful.com/learn/github-pull-request-tutorial/#:~:text=Time%20to%20Submit%20Your%20First%20PR%201%20Go,github%20username%3E%2Fguides-github-pull-request.git%20in%20your%20terminal%20More%20items...%20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Implement 2.6.3 Queue Reconfiguration or Removal in PFC watchdog HLD
Why I did it
Fix issue 2 stated in #842: "A mechanism should be introduced to let PFCWD respond to this event"
How I verified it
vs test and on brcm
vs test the following scenarios:
At each PFC enable bit change step, check
PFC_WD_STATUS
,PFC_WD_QUEUE_STATS_DEADLOCK_DETECTED
,PFC_WD_QUEUE_STATS_DEADLOCK_RESTORED
valueDetails if related
Let pfcwd orch be an observer of qos orch PFC enable bits change, and update db registration accordingly.
Fix #842
Peel off current code refactoring part in PR #1696