Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pfcwd] Observe pfc enable bits change #1697

Open
wants to merge 111 commits into
base: master
Choose a base branch
from

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Apr 6, 2021

What I did
Implement 2.6.3 Queue Reconfiguration or Removal in PFC watchdog HLD

Why I did it
Fix issue 2 stated in #842: "A mechanism should be introduced to let PFCWD respond to this event"

How I verified it
vs test and on brcm

vs test the following scenarios:

  1. Set PFC WD config on port before set any PFC enable bit
  2. Set PFC enable on {port, TC 3}
  3. Clear PFC enable on {port, TC 3}, and set PFC enable on {port, TC 4}
  4. Set big red switch mode on top of PFC WD config on port
  5. Clear PFC enable on {port, TC 4}, and set PFC enable on {port, TC 3}
  6. Clear all PFC enable bits (i.e., Clear PFC enable on {port, TC 3})

At each PFC enable bit change step, check

  • port and queue level entry in FLEX_COUNTER_DB
  • COUNTERS_DB PFC_WD_STATUS, PFC_WD_QUEUE_STATS_DEADLOCK_DETECTED, PFC_WD_QUEUE_STATS_DEADLOCK_RESTORED value
  • APPL_DB queue in-storm status

Details if related
Let pfcwd orch be an observer of qos orch PFC enable bits change, and update db registration accordingly.

Fix #842

Peel off current code refactoring part in PR #1696

wendani and others added 30 commits January 24, 2021 02:33
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
…, uint8_t pfc_bitmask_status) to PortsOrch

Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
in config is set

Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: wenda.ni <wenda.ni@bytedance.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
wendani added 24 commits April 4, 2021 05:19
…moved

Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani wendani mentioned this pull request Apr 6, 2021
1 task
@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2021

This pull request fixes 2 alerts when merging 4ce1bce into 66e1aab - view on LGTM.com

fixed alerts:

  • 2 for Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pfcwd] pfcwd does not consider the change of pfc configuraion on port
2 participants