-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mirror] Observe lag member status change #1846
Open
wendani
wants to merge
15
commits into
sonic-net:master
Choose a base branch
from
wendani:mirror_lag_member
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did These format are not wrong. But if error_handler for $? is installed, these places would cause fase positives. How I did it Update more bash syntax to avoid false positives How to verify it Run show tech support test before merge. Signed-off-by: Ying Xie ying.xie@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix #1499. In current implementation, mirror orch observes lag member add/removal event, and selects the first lag member as monitor port regardless of its lag member status, which can be disabled, such as in the case of monitor port lag member being admin down as described in #1499.
What I did
Let mirror orch observe lag member status change, notified by ports orch.
Mirror orch no longer observes lag member add event, as an added lag member can be in disabled status. Instead, mirror orch observes lag member status enabled event. Accordingly, mirror orch adjusts its monitor port selection strategy to choose the first status-enabled lag member instead of the first added lag member, but still inherits the first-fit strategy at heart.
Mirror orch observes both lag member removal event and lag member status disabled event. In the event of current mirror monitor port being removed or status disabled, first-fit monitor port selection strategy is triggered to choose the first status-enabled lag member.
How I verified it
vs test on the following cases:
Details if related
Here, we focus on the case of lag being a router interface.