Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check resource release or not before removing local vtep. #2082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iris00522
Copy link
Contributor

@iris00522 iris00522 commented Dec 15, 2021

What I did
we have added check to avoid the user tunnel
be removed earlier than local vtep, and this patch is to add to check the
vlan vni map which is also be removed earlier than local vtep.
Why I did it
testing on delete L2 vni , in test it will delete vni via restconf at same time.
if not check all evpn config deleted before delete vetp affect some resource can't released.

Mar 10 09:11:32.084398 accton-mlag-demo-001-leaf1 NOTICE swss#orchagent: :- delTunnelUser: diprefcnt for remote 10.0.0.29 = -1
Mar 10 09:11:32.084538 accton-mlag-demo-001-leaf1 ERR swss#orchagent: :- removeVlan: Failed to remove non-empty VLAN Vlan10
Mar 10 09:11:32.084688 accton-mlag-demo-001-leaf1 NOTICE swss#orchagent: :- delOperation: Vxlan tunnel 'vtep1' was removed
Mar 10 09:11:32.084688 accton-mlag-demo-001-leaf1 WARNING swss#orchagent: :- delOperation: NVO Delete failed as VTEP Ptr is NULL
Mar 10 09:11:32.085225 accton-mlag-demo-001-leaf1 NOTICE swss#orchagent: :- removeFdbEntry: FdbOrch RemoveFDBEntry: mac=04:f8:f8:6a:f9:91 bv_id=0x260000000005e2 origin 4
Mar 10 09:11:32.085246 accton-mlag-demo-001-leaf1 NOTICE swss#orchagent: :- deleteFdbEntryFromSavedFDB: FDB entry found in saved fdb. deleting...mac=04:f8:f8:6a:f9:91 vlan_id=0x3e8 origin:4 port:Port_EVPN_10.0.0.29

How I verified it
testing on delete L2 vni 10 times via restconf, the issue without happen by checking syslog.
Details if related

@iris00522 iris00522 requested a review from prsunny as a code owner December 15, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant