Create tunnel to peer switch when a packet to unresolved neighbor is received #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
This pull request introduces 1 alert when merging 5df550c into baa7476 - view on LGTM.com new alerts:
|
prsunny
reviewed
Feb 7, 2022
| @@ -728,6 +730,11 @@ void NeighOrch::doTask(Consumer &consumer) | |||
| if (m_syncdNeighbors.find(neighbor_entry) == m_syncdNeighbors.end() | |||
| || m_syncdNeighbors[neighbor_entry].mac != mac_address) | |||
| { | |||
| if (mac_address == MacAddress("00:00:00:00:00:00")) | |||
There was a problem hiding this comment.
Looks like there is more change here and the muxorch changes.
prsunny
reviewed
Feb 8, 2022
| fvs1 = asicdb.get_entry(self.ASIC_ROUTE_TABLE, route) | ||
| oid = fvs1["SAI_ROUTE_ENTRY_ATTR_NEXT_HOP_ID"] | ||
| fvs2 = asicdb.get_entry(self.ASIC_NEXTHOP_TABLE, oid) | ||
| assert fvs2["SAI_NEXT_HOP_ATTR_IP"] == "10.1.0.32" |
There was a problem hiding this comment.
please use function dvs_route.check_asicdb_route_entries for checking asic_db
| dst_ip="10.1.0.32", dscp_mode="uniform", | ||
| ecn_mode="standard", ttl_mode="pipe") | ||
|
|
||
| peer_attrs = { |
There was a problem hiding this comment.
Please add the following tests as well:
- Add a FAILED neighbor before configuring peer_switch. There should not be a tunnel route
- Do mux status changes after resolving the entry and verify neighbor, and tunnel route
- Add a FAILED entry and delete the entry. Make sure the tunnel route is removed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
To handle the case when a packet to an unresolved neighbor is received, the ToR will create a tunnel to the peer and forward the packet to the peer.
How I verified it
Write virtual switch tests
Details if related